Solution for the issues described in #152 #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These settings allow to prefix the output with a header string and to append a footer at the end of the stream. Additionally, the separator between objects can be now changed. Previously, this was always a newline character. The default settings of header, footer and separator are chosen so that the output of ObjectWriter is the same as in the old version of the module (i.e. a new line character is append to each object). In addition to these new options the encoding and compression options can now be set via Flux. This commit offers a solution for issue metafacture#152: The output of the JSON encoder can be turned into a JSON array by setting header to "[", separator to ", " and footer to "]".
Starting from the second object JsonEncoder added a space character to each serialised object it generated (as pointed out in issue metafacture#152). This commit changes the configuration of the JSON generator used by JsonEncoder to not output these spaces.
cboehme
added a commit
that referenced
this pull request
Dec 4, 2013
Solution for the issues described in #152
blackwinter
added a commit
to blackwinter/metafacture-core
that referenced
this pull request
Oct 16, 2017
Jackson's JsonGenerator doesn't apply configured root value separator to pretty-printer. Ref.: metafacture#153 (d84456a)
blackwinter
added a commit
that referenced
this pull request
Dec 13, 2024
blackwinter
pushed a commit
that referenced
this pull request
Dec 13, 2024
blackwinter
pushed a commit
that referenced
this pull request
Dec 13, 2024
blackwinter
pushed a commit
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit extends
ObjectWriterto output user-defined header, footer and separator strings. The second one fixes the output of unnecessary spaces byJsonEncoder.