Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUDA image caching: when setting new cam HPR/Pos, cuda image is not updated. #788

Merged
merged 2 commits into from
Dec 15, 2024

Conversation

pengzhenghao
Copy link
Member

@pengzhenghao pengzhenghao commented Dec 15, 2024

… cuda image is not updated.

What changes do you make in this PR?

  • Please describe why you create this PR

close #775

Before:

image_on_cuda=False:

multiview_observation_no_image_on_cuda_no_fix

image_on_cuda=True:

multiview_observation_with_image_on_cuda_no_fix

After fix:

image_on_cuda=False:

multiview_observation_no_image_on_cuda

image_on_cuda=True:

multiview_observation_image_on_cuda

Checklist

  • I have merged the latest main branch into current branch.
  • I have run bash scripts/format.sh before merging.
  • Please use "squash and merge" mode.

@pengzhenghao pengzhenghao enabled auto-merge (squash) December 15, 2024 21:29
@pengzhenghao pengzhenghao changed the title Fix a bug caused by CUDA image caching: when setting new cam HPR/Pos,… CUDA image caching: when setting new cam HPR/Pos, cuda image is not updated. Dec 15, 2024
@pengzhenghao pengzhenghao merged commit 4111ff5 into main Dec 15, 2024
13 of 14 checks passed
@pengzhenghao pengzhenghao deleted the imgcuda branch December 15, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi View issue: "image_on_cuda":True affects camera observe parameter 'hpr' mistake
1 participant