Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix the bugs introduced by bounding box env #778

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Hotfix the bugs introduced by bounding box env #778

merged 3 commits into from
Dec 6, 2024

Conversation

pengzhenghao
Copy link
Member

What changes do you make in this PR?

  • Please describe why you create this PR

The bugs are:

  1. If use log replay ego policy, the visualization will be flickerring because the agent update position each step. Solution: introduce config set_static and default to False. Need to turn it on in SimGen.
  2. The tire of the agents are completely wrong in ScenarioEnv. Some agents might miss their tires. This is fixed by only passing in vehicle_config['scale'] when using bounding box.

Checklist

  • I have merged the latest main branch into current branch.
  • I have run bash scripts/format.sh before merging.
  • Please use "squash and merge" mode.

@pengzhenghao pengzhenghao enabled auto-merge (squash) December 6, 2024 04:39
@pengzhenghao pengzhenghao merged commit 6b19a02 into main Dec 6, 2024
14 checks passed
@pengzhenghao pengzhenghao deleted the hotfix branch December 6, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pengzhenghao