Merge and splits for ramp #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO:
|
|
Great. The ramp's structure is more reasonable now. Is it ready to merge? |
|
@fredyshox Thanks for contributions! Is this PR ready to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes do you make in this PR?
Add ExtendingLane, replacing the CircularLane as a decoration for InRampOnStraight or OutRampOnStraight. This make the exits/merges look more realistic (at least in the US).
Length of the decoration and lane is controlled by
lengthandextension_lengthparametersWe intend to use it for evaluating the behaviour of our driving model around exists/merges.
OutRampOnStraight:
InRampOnStraight:
Checklist
bash scripts/format.shbefore merging.