Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more examples for semantic observation/sensor in docs #669

Merged
merged 3 commits into from
Mar 2, 2024

Conversation

pengzhenghao
Copy link
Member

@pengzhenghao pengzhenghao commented Mar 2, 2024

What changes do you make in this PR?

  • Please describe why you create this PR

close #650 by providing better example in documentation.

close #643

Checklist

  • I have merged the latest main branch into current branch.
  • I have run bash scripts/format.sh before merging.
  • Please use "squash and merge" mode.

@pengzhenghao pengzhenghao added the Merge after all tests pass Merge this PR when all tests pass! label Mar 2, 2024
@pengzhenghao pengzhenghao changed the title update obs.ipynb Add more examples for semantic observation/sensor in docs Mar 2, 2024
@pengzhenghao pengzhenghao merged commit e7c1f47 into main Mar 2, 2024
13 of 14 checks passed
@pengzhenghao pengzhenghao deleted the fix-ren branch March 2, 2024 06:49
@QuanyiLi
Copy link
Member

QuanyiLi commented Mar 2, 2024

There is an environment variable TEST_DOC which will be set to 1 when doing CI. You can set the episode length to very short when doing CI with this key turned on. So the test won't take more than 300s and trigger the out-of-time failure. I did a lot of similar things when building doc, which are good references for you.

@pengzhenghao
Copy link
Member Author

pengzhenghao commented Mar 2, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge after all tests pass Merge this PR when all tests pass!
Projects
None yet
2 participants