feat: add centralized error handler middleware#152
Open
Nishal77 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a centralized Express error handler middleware that catches all unhandled errors and returns consistent JSON responses. Also fixes
src/controller/error.tswhich was usingres.send()(plain text) instead ofres.json(), causing client-side parse failures.Related issue
Fixes #151
Type of change
How to test
npm cinpm startcurl -s http://localhost:9000/nonexistent | python3 -m json.tool{ "error": "fail", "message": "Can't find /nonexistent on this server!", "statusCode": 404 }curl -s http://localhost:9000/health | python3 -m json.toolChecklist
Notes for reviewers
src/middleware/errorHandler.ts— new file, named exporterrorHandler, four-param Express error handler (required for Express to recognize it as error middleware)src/index.ts— two lines added: import +app.use(errorHandler)afterinitializeAPI()src/controller/error.ts—res.send()changed tores.json()for consistent JSON shape across all errorsRelease notes
Centralized error handler now returns consistent JSON
{ error, message, statusCode }for all unhandled errors.