Feat/Lua loader#781
Open
k5602 wants to merge 12 commits into
Open
Conversation
Enhance the Lua loader to correctly identify empty tables as maps and improve function reflection to support variadic arguments by allowing up to 64 parameters. Additionally, improve the robustness of table-to-array conversion by verifying consecutive indexing and add a comprehensive test suite covering numeric boundaries, string edge cases, and mixed types.
Use early returns in Lua to value conversion and remove redundant name and handle fields from the internal function structure.
… a stack-use-after-scope
Implement native integer detection for Lua 5.3+ and improve conversion safety for Lua 5.1/LuaJIT by using a 2^53 safe integer limit. Integral numbers are now mapped to METACALL_LONG instead of METACALL_INT. Additionally, standardize header includes and increase recursion depth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a robust, production-ready Lua loader for MetaCall, transitioning from standard scaffolded Lua to LuaJIT. It introduces a complete value conversion system, enhanced function discovery, and comprehensive edge-case testing.
Key Changes
FindLuaJIT.cmakeand updated the build system to prioritize LuaJIT for improved performance and integration.lua_loader_convert.cwhich handles bidirectional conversion between Lua tables (detecting both arrays and maps) and MetaCall types, including a safety recursion limit of 10 as a best practice.debug.getinfoto introspect parameter counts and supports variadic functions (up to 64 arguments).metacall_lua_mixed_test, a comprehensive test suite covering 40+ scenarios including numeric boundaries (INT64), Unicode strings, sparse arrays, and multiple return values.Closes #675
Type of change
Checklist:
make testorctest -VV -R <test-name>)../docker-compose.sh test &> outputand attached the output.OPTION_BUILD_ADDRESS_SANITIZERor./docker-compose.sh test-address-sanitizer &> outputandOPTION_TEST_MEMORYCHECK.OPTION_BUILD_THREAD_SANITIZERor./docker-compose.sh test-thread-sanitizer &> output.Helgrindin case my code works with threading.make clang-formatin order to format my code and my code follows the style guidelines.