Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated windows-test.yml #507

Closed
wants to merge 2 commits into from
Closed

Conversation

shaggyyy2002
Copy link
Contributor

Description

In this I have added the repository dispatch so that it will trigger the windows-dist repo, only if it passes all the windows tests mentioned.

Fixes #505 Connect Core CI with Distributable's Repo

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests/screenshots (if any) that prove my fix is effective or that my feature works.
  • I have tested the tests implicated (if any) by my own code and they pass (make test or ctest -VV -R <test-name>).
  • If my change is significant or breaking, I have passed all tests with ./docker-compose.sh test &> output and attached the output.
  • [ X I have tested my code with OPTION_BUILD_ADDRESS_SANITIZER or ./docker-compose.sh test-address-sanitizer &> output and OPTION_TEST_MEMORYCHECK.
  • [ X I have tested my code with OPTION_BUILD_THREAD_SANITIZER or ./docker-compose.sh test-thread-sanitizer &> output.
  • I have tested with Helgrind in case my code works with threading.
  • I have run make clang-format in order to format my code and my code follows the style guidelines.

In this I have added the repository dispatch so that it will trigger the windows-dist repo, only if it passes all the windows tests mentioned
Copy link
Contributor Author

@shaggyyy2002 shaggyyy2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing the repo destination on line 77
repository: shaggyyy2002/distributable-windows

@viferga
Copy link
Member

viferga commented Jun 19, 2024

Duplicated.

@viferga viferga closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect Core CI with Distributable's Repo
2 participants