Skip to content

Add base for NodeJS async implementation and MetaCall support for Futures. #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Aug 28, 2019

Conversation

viferga
Copy link
Member

@viferga viferga commented Aug 19, 2019

No description provided.

@viferga
Copy link
Member Author

viferga commented Aug 22, 2019

At current state, the then gets executed but the resolve callback never goes back to C. It only gets executed when the thread join on the destroy method of the node loader. So this may be a race condition or deadlock caused by calling JavaScript from C without protection (i.e executing the then method without protection from an asynchronous procedure).

Documentation:

There is a need to test if threadsafe functions work properly. In that case, the introspection function must be changed in order to allow creating threadsafe functions on start if it detects async, because creating them while the execution may be an overhead.

Further investigation is needed to see how the callback is being passed to JS and invoked. So we should do more investigation.

@viferga viferga merged commit 590521b into develop Aug 28, 2019
@viferga viferga deleted the feature/nodejs_async branch July 22, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant