Skip to content

Nice to have: platform independent Bash, armv6j support #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

grepwood
Copy link

b89932c adds support for FreeBSD by changing #!/bin/bash to #!/usr/bin/env bash
3909d46 adds armv6j support by properly handling va_list

viferga added a commit that referenced this pull request May 27, 2019
@viferga
Copy link
Member

viferga commented May 27, 2019

@grepwood review if this commit works on armv6j architecture: 4292faa

@viferga
Copy link
Member

viferga commented Aug 19, 2019

I solved it here but I forgot to close this: 4292faa

This approach is similar to yours but more general, so it may be able to work in multiple architectures. Wrapping the va_args unifies the access to it. I took the source from here:
https://bitbucket.org/parrastudios/argentum-online-c/src/master/common/src/Portability/VariableArguments.h

@viferga viferga closed this Aug 19, 2019
RohanKrMahato pushed a commit to RohanKrMahato/core that referenced this pull request Dec 9, 2024
[FIX] Add to Path without admin privileges
RohanKrMahato pushed a commit to RohanKrMahato/core that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants