Skip to content

[WIP] SEARCH-738 / SEARCH-739 (indexer): Support and search by medium MBIDs #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

reosarevok
Copy link
Member

Problem: SEARCH-738 / SEARCH-739 (indexer part)

metabrainz/musicbrainz-server#3502 adds MBIDs to mediums, so they should also be added to the relevant search indexes.

Solution

  • Set id for medium in wscompat using the gid (needs to be tested to see if it needs loading explicitly or not).

Test hints

Using musicbrainz-docker and sample data dump, rebuild the 3 search indexes with:

sudo docker-compose exec indexer python -m sir reindex --entity-type release --entity-type recording

Then query the web service (in XML):

  • /ws/2/recording?query=rid:52bc6f21-2c6d-48d0-be24-6ddb06a8461c
  • /ws/2/release/?query=reid:6473ff12-496f-3fb8-a94a-65d565487885

(Note that XML/JSON formatting will be covered by CI tests in the associated mb-solr PR [to be linked here]).

Checklist for author

  • [] Test this locally with the mb-solr PR and a new mb-rngpy test version
  • Have a new release of mmd-schema
  • Have a new release of mb-rngpy based on it
  • Use that release instead of the test version in requirements.txt
  • Test locally with that release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant