Port Sir to Py3 SEARCH-594 #109
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Place holder PR,not completely done with the port yet. |
sambhav
reviewed
Dec 26, 2019
|
Please note that SOLR-112 has just been moved to SEARCH-594. |
|
@Pac23, also there is no need for a |
Updated to Search-594 |
|
To be fair, I didn’t expect that port to be so complicated. It seems necessary to address one issue after the other by splitting this task into smaller actionable steps that can be reviewed, tested and merged gradually. Thus, I opened the small pull request #110 to prepare for Python 3, reviews are welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of Sir to Py3 SOLR-112
Problem
Python2 EOL In jan 2020
Solution
Porting to Py3 Before EOL of Py2
Action
Create a Py3 Branch for this,i dont have acess to creating one @yvanzo