Skip to content

PICARD-2437: Use a Ok button instead of Save in tag edit dialog #2077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2022
Merged

PICARD-2437: Use a Ok button instead of Save in tag edit dialog #2077

merged 1 commit into from
Mar 10, 2022

Conversation

phw
Copy link
Member

@phw phw commented Mar 10, 2022

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

Use a Ok button instead of Save in tag edit dialog. Avoids misunderstanding that the changes are actually saved to the file

@phw phw requested a review from zas March 10, 2022 13:14
@rdswift rdswift mentioned this pull request Mar 10, 2022
Open
5 tasks
@zas zas merged commit 2992e65 into metabrainz:master Mar 10, 2022
@phw phw deleted the PICARD-2437-tageditdialog-ok-instead-of-save branch March 12, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zas zas zas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phw @zas