resintate db and fix templates #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nllho
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
The home page looks good 👍
This might be out of scope for this PR (or I'm missing a prerequisite?) but the embeds at the links under the "Signed embedding" section are broken.
- An example of a specific User's dashboard
- An example of a specific User's chart
- An example of a public signed dashboard
I have some thoughts on making the README clearer too. Will add notes here:
https://www.notion.so/Update-README-for-embedding-reference-apps-6f36efcde1d74c42809f6bbd1ad41f46
|
@nllho confirmed that the fixes worked when she tried in a fresh repo. Merging this now to get the fix in; we can follow up with improvements in future PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only updated the Node app. If this PR gets merged, I can tackle the other deployments.
That said, this code dates back the previous decade, and could use a major update. This PR just brings the Node app up from broken to not broken.
Feedback requested