-
Notifications
You must be signed in to change notification settings - Fork 55
Add Laravel Implementation Example #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stefanzweifel thank you so much for this!
Is there any way you can take our templates in the other applications and re-use them? We include a lot of explanatory text and show multiple ways to embed things that is very useful to end developers
Sure. Do you have a link or something where I can see an example? (I'm not really fluent in django or rails ...) |
https://github.com/metabase/embedding-reference-apps/tree/master/rails/embedded_analytics/app/views/ for rails |
Copied and modified from the Rails Embedding Example App
Hey @salsakran, I've just pushed a commit which adds your default templates to the Laravel App. When running the app with |
Should we merge this? Appears @salsakran approved the changes. |
I've held off to figure out what license we should use.
At this point, I *think* it should be MIT, but I'm not sure. Alternatively,
Stefan, do you mind signing our CLA?
https://docs.google.com/forms/d/e/1FAIpQLSfc9GWyJ3F9U_4NzHLeTblgtog1FKtG3CjLshE4FAAKSdvNoQ/viewform
…On Wed, Jun 21, 2017 at 4:16 PM, Maz Ameli ***@***.***> wrote:
Should we merge this? Appears @salsakran <https://github.com/salsakran>
approved the changes.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGjr5ZUnDiRQU-USpHglmsv02QqFRsBks5sGaRagaJpZM4NsEQW>
.
|
CLA is signed. Should I add this to my version? |
Thanks! I'm not clear on what license autogenerated scaffolding would be. It seems like it is "yours" and hence doesn't need an explicit carry over of the laravel license. I'm cool either way. We'll probably be releasing this under MIT anyway. |
Sounds good to me. Thanks for the merge ✨ |
thank you for the help, and your patience! |
First thanks for Metabase!. It's such a great application and all the recent releases have been awesome.
This PR adds an embedding example for the popular PHP framework Laravel. A lot of the code is framework stuff. The implementation has been added in 8defa23.
The signing of the JWT token is done here. The iframe is rendered here.
I've also added a short README with instructions on what's been added.