Skip to content

Add Laravel Implementation Example #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 22, 2017
Merged

Add Laravel Implementation Example #1

merged 6 commits into from
Jun 22, 2017

Conversation

stefanzweifel
Copy link
Contributor

First thanks for Metabase!. It's such a great application and all the recent releases have been awesome.

This PR adds an embedding example for the popular PHP framework Laravel. A lot of the code is framework stuff. The implementation has been added in 8defa23.

The signing of the JWT token is done here. The iframe is rendered here.

I've also added a short README with instructions on what's been added.

@salsakran salsakran self-requested a review June 6, 2017 21:02
Copy link
Contributor

@salsakran salsakran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefanzweifel thank you so much for this!

Is there any way you can take our templates in the other applications and re-use them? We include a lot of explanatory text and show multiple ways to embed things that is very useful to end developers

@stefanzweifel
Copy link
Contributor Author

Sure. Do you have a link or something where I can see an example? (I'm not really fluent in django or rails ...)

Copied and modified from the Rails Embedding Example App
@stefanzweifel
Copy link
Contributor Author

stefanzweifel commented Jun 8, 2017

Hey @salsakran, I've just pushed a commit which adds your default templates to the Laravel App. When running the app with php artisan serve and visiting http://localhost:8000 the app serves your explanatory templates.

@mazameli
Copy link

Should we merge this? Appears @salsakran approved the changes.

@salsakran
Copy link
Contributor

salsakran commented Jun 21, 2017 via email

@stefanzweifel
Copy link
Contributor Author

CLA is signed.
I just realised that the used copy of Laravel doesn't include a LICENSE file. Here's the original.

Should I add this to my version?

@salsakran
Copy link
Contributor

Thanks! I'm not clear on what license autogenerated scaffolding would be. It seems like it is "yours" and hence doesn't need an explicit carry over of the laravel license. I'm cool either way. We'll probably be releasing this under MIT anyway.

@salsakran salsakran merged commit 67aeb5c into metabase:master Jun 22, 2017
@stefanzweifel
Copy link
Contributor Author

Sounds good to me. Thanks for the merge ✨

@stefanzweifel stefanzweifel deleted the add-laravel-example branch June 22, 2017 18:00
@salsakran
Copy link
Contributor

thank you for the help, and your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants