Skip to content

Feature selection on dataset_view instead of forward_index #149

@siddshuk

Description

@siddshuk

feature_selector requires a forward_index to be passed in to the constructor. But the forward_index is built on the entire dataset, which includes training and test data.

Feature selection should be done on training data separately without touching the test data to avoid optimistically biased performance estimates during cross-validation.

Is it possible to allow feature selection to be done on a dataset_view (view for the training portion of the dataset in this case)?

Thanks.

Best Regards,
Sid

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions