Add gzip support for load_ndjson() #207
Closed
+45
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support .ndjson.gz (gzip compressed) files - Support .bin.ndjson (gzip member concatenation) files - Add _is_gzip_file() helper function - Add test using existing .ndjson.gz test file
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for loading gzip-compressed NDJSON files in the
load_ndjson()function, fixing an issue where the CLI claimed to support.ndjson.gzfiles but the function only usedopen().Supported Formats
.ndjson.ndjson.gz.bin.ndjsonChanges
tools/prettify_ndjson.py:import gzip_is_gzip_file()helper function to detect compressed filesload_ndjson()to usegzip.open()for compressed filestests/test_tritonparse.py:test_load_ndjson_gzip_support()test using existing.ndjson.gztest fileTesting
Uses existing test file:
tests/example_output/parsed_output_complex/dedicated_log_triton_trace_findhao__mapped.ndjson.gz