Change --line to 0-based index for reproduce command #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The --line argument is now 0-based instead of 1-based. - --line 0 now refers to the first event (previously --line 1) - Default value changed from 1 to 0 - Removed the -1 conversion in cli.py This aligns with Python's 0-based indexing convention. Also includes: - Fix import order in tritonbench template - Update pip install to use -U flag in Makefile
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the
--lineargument in thereproducecommand from 1-based to 0-based indexing, aligning with Python conventions.Changes
reproducer/cli.py: Changed--linedefault from 1 to 0, updated help text to indicate 0-based indexingcli.py: Removed the-1conversion, updated CLI example to use--line 1README.md: Updated example with explanation that line 0 is compilation event, line 1 is first launch eventreproducer/templates/tritonbench.py: Fixed import order (lint fix)Makefile: Added-Uflag to pip install (minor fix)Breaking Change
The
--lineargument is now 0-based instead of 1-based:--line 0= first event (compilation)--line 1= second event (first launch)Users who previously used
--line 1to get the first event should now use--line 0.Testing
Existing
test_reproducer_end_to_endtest already uses 0-basedline_indexinternally, no test changes needed.