Skip to content

(torchx/runner) properly log appdef properties in dryrun #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2025
Merged

(torchx/runner) properly log appdef properties in dryrun #1159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion torchx/runner/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ def dryrun(
scheduler,
runcfg=json.dumps(cfg) if cfg else None,
workspace=str(workspace),
):
) as ctx:
sched = self._scheduler(scheduler)
resolved_cfg = sched.run_opts().resolve(cfg)

Expand Down Expand Up @@ -450,6 +450,14 @@ def dryrun(
sched._validate(app, scheduler, resolved_cfg)
dryrun_info = sched.submit_dryrun(app, resolved_cfg)
dryrun_info._scheduler = scheduler

event = ctx._torchx_event
event.scheduler = scheduler
event.runcfg = json.dumps(cfg) if cfg else None
event.app_id = app.name
event.app_image = none_throws(dryrun_info._app).roles[0].image
event.app_metadata = app.metadata

return dryrun_info

def scheduler_run_opts(self, scheduler: str) -> runopts:
Expand Down
Loading