-
Notifications
You must be signed in to change notification settings - Fork 146
feat: add delete command, make cancel abort for k8s (#1156) #1158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Please check this proposal, @kiukchung Let me know if you want to limit the scope to just change the behavior of |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1158 +/- ##
==========================================
- Coverage 91.62% 91.58% -0.05%
==========================================
Files 84 85 +1
Lines 6589 6617 +28
==========================================
+ Hits 6037 6060 +23
- Misses 552 557 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Some testing evidence @kiukchung
If the above looks good I guess the only question is if we want to print anything when we try to delete and do it, or skip if it does not exists. |
a108deb to
dd1fbec
Compare
|
@kiukchung has imported this pull request. If you are a Meta employee, you can view this in D85961055. |
dd1fbec to
3dbf4b4
Compare
|
Updated the docstring, @kiukchung |
|
Hm, that Meta Internal-Only Changes Check is failing again, did I do something wrong, @kiukchung ? |
Make k8s scheduler
cancelabort the job, instead of removing it completely.Adding
deletecommand for all schedulers to override, default implementation callscancelto mimic the current behavior.Test plan:
[x] added unit tests