Skip to content

remove the unnecessary fx wrapped function in test_model #2900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

remove the unnecessary fx wrapped function in test_model #2900

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions torchrec/distributed/test_utils/test_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1285,7 +1285,6 @@ def forward(
for fp in self.fps:
fp_features = fp(fp_features)
ebc = self.ebc(features)
ebc = _post_ebc_test_wrap_function(ebc)
fp_ebc: Optional[KeyedTensor] = (
self.fp_ebc(fp_features) if self.fp_ebc is not None else None
)
Expand Down Expand Up @@ -1911,14 +1910,6 @@ def _get_default_rtol_and_atol(
return max(actual_rtol, expected_rtol), max(actual_atol, expected_atol)


@torch.fx.wrap
def _post_ebc_test_wrap_function(kt: KeyedTensor) -> KeyedTensor:
for _ in kt.values():
continue

return kt


class TestPreprocNonWeighted(nn.Module):
"""
Basic module for testing
Expand Down Expand Up @@ -2374,7 +2365,6 @@ def forward(
KeyedTensor
"""
ebc, _ = self.ebc(features)
ebc = _post_ebc_test_wrap_function(ebc)
w_ebc, _ = (
self.weighted_ebc(weighted_features)
if self.weighted_ebc is not None and weighted_features is not None
Expand Down
Loading