Do not ignore None arg when pipelining
#2352
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61938346 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61938346 |
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Aug 30, 2024
Summary: Pull Request resolved: meta-pytorch#2352 if `arg` to embedding module is `None`, we would ignore it. However, now we also use `_get_node_args_helper` to generate arg list info for preproc modules, and sometimes `None` is passed in as arg/kwarg. With changes in meta-pytorch#2342, we can now handle constants. For backward compatibility, adding an optional flag to indicate to `_get_node_args_helper` that we are handling preproc modules. Reviewed By: xing-liu Differential Revision: D61938346
sarckk
force-pushed
the
export-D61938346
branch
from
663f78a to
655e4f4
Compare
Summary: Pull Request resolved: meta-pytorch#2352 if `arg` to embedding module is `None`, we would ignore it. However, now we also use `_get_node_args_helper` to generate arg list info for preproc modules, and sometimes `None` is passed in as arg/kwarg. With changes in meta-pytorch#2342, we can now handle constants. For backward compatibility, adding an optional flag to indicate to `_get_node_args_helper` that we are handling preproc modules. Reviewed By: xing-liu Differential Revision: D61938346
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61938346 |
sarckk
force-pushed
the
export-D61938346
branch
from
655e4f4 to
b9b74ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
if
argto embedding module isNone, we would ignore it. However, now we also use_get_node_args_helperto generate arg list info for preproc modules, and sometimesNoneis passed in as arg/kwarg.With changes in #2342, we can now handle constants. For backward compatibility, adding an optional flag to indicate to
_get_node_args_helperthat we are handling preproc modules.Reviewed By: xing-liu
Differential Revision: D61938346