Enable TW pruning, no remapping #2343
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61879687 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61879687 |
PaulZhang12
added a commit
to PaulZhang12/torchrec
that referenced
this pull request
Aug 29, 2024
…ows post pruning (meta-pytorch#2343) Summary: Pull Request resolved: meta-pytorch#2343 Enable TW pruning for TorchRec inference modules. We switch from pruned_indices_remapping to num_rows_post_pruning given the fact that the indices remapping isn't calculated until after physical transformations. Logical transformations (optimizing the model itself) should not depend on the reset of physical transformations, and the actual index remapping will be set later on in model loading Differential Revision: D61879687
PaulZhang12
force-pushed
the
export-D61879687
branch
from
7deaaac to
33c4a4f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61879687 |
PaulZhang12
added a commit
to PaulZhang12/torchrec
that referenced
this pull request
Aug 30, 2024
…ows post pruning (meta-pytorch#2343) Summary: Pull Request resolved: meta-pytorch#2343 Enable TW pruning for TorchRec inference modules. We switch from pruned_indices_remapping to num_rows_post_pruning given the fact that the indices remapping isn't calculated until after physical transformations. Logical transformations (optimizing the model itself) should not depend on the reset of physical transformations, and the actual index remapping will be set later on in model loading Reviewed By: dstaay-fb Differential Revision: D61879687
PaulZhang12
force-pushed
the
export-D61879687
branch
from
33c4a4f to
89f75ee
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61879687 |
PaulZhang12
added a commit
to PaulZhang12/torchrec
that referenced
this pull request
Aug 30, 2024
…ows post pruning (meta-pytorch#2343) Summary: Pull Request resolved: meta-pytorch#2343 Enable TW pruning for TorchRec inference modules. We switch from pruned_indices_remapping to num_rows_post_pruning given the fact that the indices remapping isn't calculated until after physical transformations. Logical transformations (optimizing the model itself) should not depend on the reset of physical transformations, and the actual index remapping will be set later on in model loading Reviewed By: dstaay-fb Differential Revision: D61879687
PaulZhang12
force-pushed
the
export-D61879687
branch
from
89f75ee to
1c73501
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61879687 |
PaulZhang12
added a commit
to PaulZhang12/torchrec
that referenced
this pull request
Aug 30, 2024
…ows post pruning (meta-pytorch#2343) Summary: Pull Request resolved: meta-pytorch#2343 Enable TW pruning for TorchRec inference modules. We switch from pruned_indices_remapping to num_rows_post_pruning given the fact that the indices remapping isn't calculated until after physical transformations. Logical transformations (optimizing the model itself) should not depend on the reset of physical transformations, and the actual index remapping will be set later on in model loading Reviewed By: dstaay-fb Differential Revision: D61879687
PaulZhang12
force-pushed
the
export-D61879687
branch
from
1c73501 to
f7b8ef9
Compare
…ows post pruning (meta-pytorch#2343) Summary: Pull Request resolved: meta-pytorch#2343 Enable TW pruning for TorchRec inference modules. We switch from pruned_indices_remapping to num_rows_post_pruning given the fact that the indices remapping isn't calculated until after physical transformations. Logical transformations (optimizing the model itself) should not depend on the reset of physical transformations, and the actual index remapping will be set later on in model loading Reviewed By: dstaay-fb Differential Revision: D61879687
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61879687 |
PaulZhang12
force-pushed
the
export-D61879687
branch
from
f7b8ef9 to
f83d35b
Compare
PaulZhang12
added a commit
to PaulZhang12/torchrec
that referenced
this pull request
Sep 3, 2024
…ows post pruning (meta-pytorch#2343) Summary: Pull Request resolved: meta-pytorch#2343 Enable TW pruning for TorchRec inference modules. We switch from pruned_indices_remapping to num_rows_post_pruning given the fact that the indices remapping isn't calculated until after physical transformations. Logical transformations (optimizing the model itself) should not depend on the reset of physical transformations, and the actual index remapping will be set later on in model loading Differential Revision: D61879687 Reviewed By: dstaay-fb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Enable TW pruning for TorchRec inference modules. We switch from pruned_indices_remapping to num_rows_post_pruning given the fact that the indices remapping isn't calculated until after physical transformations. Logical transformations (optimizing the model itself) should not depend on the reset of physical transformations, and the actual index remapping will be set later on in model loading
Differential Revision: D61879687