lighthouse: add commit_failures support #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
d4l3k
force-pushed
the
d4l3k/recover_errors
branch
from
161af71 to
cd3a73d
Compare
H-Huang
approved these changes
May 1, 2025
src/lighthouse.rs
Outdated
| } else if participants.iter().map(|p| p.commit_failures).sum::<i64>() > 0 { | ||
| state.quorum_id += 1; | ||
| info!( | ||
| "Detected commit failures, bumping quorum_id to {}", |
Contributor
There was a problem hiding this comment.
nit: maybe not necessary since the manager already logs it, but for lighthouse we could also log the participants with commit failures here?
d4l3k
force-pushed
the
d4l3k/recover_errors
branch
from
cd3a73d to
e41fd5c
Compare
d4l3k
force-pushed
the
d4l3k/recover_errors
branch
from
e41fd5c to
7ffa3e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new field to Lighthouse quorum for
commit_failures. When a commit failure occurs, a network error has occurred and we thus force a new quorum to ensure that all workers reconfigure.This is required so #182 will gracefully recover after failure.
Test plan: