Rename CE helper and host worker queue - #4281
Open
enginarslan1 wants to merge 1 commit into
Open
enginarslan1 wants to merge 1 commit into
enginarslan1 wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@enginarslan1 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D122595108. |
Summary: Frees up the `HostCollectiveEngine` name for the class that actually drives host-side collective execution. - `comms/mccl/prims/HostCollectiveEngine` becomes `CEOperator`. It is a thin, stateless wrapper over Copy-Engine copies and CUDA stream memory ops -- an operator on the Copy Engine, not an engine in its own right -- and the old name overstated its role. - `comms/mccl/collectives/HostWorkerQueue` becomes `HostCollectiveEngine`. This is the FIFO worker thread that runs a collective's host sequence off the caller's thread, which is the component the name belongs to. Pure rename: no behavior, signature, or ownership changes. Files, test suite names, and the host-driven AllGather design note move with the classes. Differential Revision: D122595108
enginarslan1
force-pushed
the
export-D122595108
branch
from
September 30, 2026 17:34
c5e65f5 to
4551a0d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Frees up the
HostCollectiveEnginename for the class that actually drives host-side collective execution.comms/mccl/prims/HostCollectiveEnginebecomesCEOperator. It is a thin, stateless wrapper over Copy-Engine copies and CUDA stream memory ops -- an operator on the Copy Engine, not an engine in its own right -- and the old name overstated its role.comms/mccl/collectives/HostWorkerQueuebecomesHostCollectiveEngine. This is the FIFO worker thread that runs a collective's host sequence off the caller's thread, which is the component the name belongs to.Pure rename: no behavior, signature, or ownership changes. Files, test suite names, and the host-driven AllGather design note move with the classes.
Differential Revision: D122595108