Repository navigation
Expose attribution forward progress for runtime estimation (#1933) - #1933
Open
Rollingkeyboard wants to merge 1 commit into
Open
Rollingkeyboard wants to merge 1 commit into
Rollingkeyboard wants to merge 1 commit into
Conversation
Contributor
|
@Rollingkeyboard has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120368627. |
meta-codesync
Bot
changed the title
Rollingkeyboard
force-pushed
the
export-D120368627
branch
from
September 18, 2026 15:17
c23bd99 to
9d0640f
Compare
meta-codesync
Bot
changed the title
Rollingkeyboard
pushed a commit
to Rollingkeyboard/captum
that referenced
this pull request
Sep 21, 2026
…rch#1933) Summary: Replace the thread-local progress-bar interception with an explicit model-forward progress contract. Attribution algorithms publish an exact batch-scoped forward plan, including grouped and individual-feature work, and FeatureAttributor reports only successfully completed model forwards. Failed forwards invalidate the estimate. This keeps the existing FeatureAttributor.set_progress_callback(total, increment) consumer API while supporting first-batch ETA after the first completed Captum forward. Unsupported algorithms disable reporting instead of publishing an unsafe estimate. Differential Revision: D120368627
Rollingkeyboard
force-pushed
the
export-D120368627
branch
from
September 21, 2026 21:40
9d0640f to
85a294d
Compare
…rch#1933) Summary: Replace the thread-local progress-bar interception with an explicit model-forward progress contract. Attribution algorithms publish an exact batch-scoped forward plan, including grouped and individual-feature work, and FeatureAttributor reports only successfully completed model forwards. Failed forwards invalidate the estimate. This keeps the existing FeatureAttributor.set_progress_callback(total, increment) consumer API while supporting first-batch ETA after the first completed Captum forward. Unsupported algorithms disable reporting instead of publishing an unsafe estimate. Differential Revision: D120368627
Rollingkeyboard
force-pushed
the
export-D120368627
branch
from
September 21, 2026 21:43
85a294d to
0629b24
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Replace the thread-local progress-bar interception with an explicit model-forward progress contract. Attribution algorithms publish an exact batch-scoped forward plan, including grouped and individual-feature work, and FeatureAttributor reports only successfully completed model forwards. Failed forwards invalidate the estimate.
This keeps the existing FeatureAttributor.set_progress_callback(total, increment) consumer API while supporting first-batch ETA after the first completed Captum forward. Unsupported algorithms disable reporting instead of publishing an unsafe estimate.
Differential Revision: D120368627