Fix DeepLift adjacent nonlinear hooks (#1104) (#1843)#1843
Open
craymichael wants to merge 1 commit into
Open
Conversation
Contributor
|
@craymichael has imported this pull request. If you are a Meta employee, you can view this in D106053881. |
…ch#1843) Summary: Fixes meta-pytorch#1104. Issue: meta-pytorch#1104 Issue summary: adjacent supported nonlinear modules could use stale output gradients in DeepLift. - Capture non-inplace module output gradients with a full backward pre-hook. - Keep the tensor-output fallback for inplace modules. - Add a regression test for adjacent MaxPool and ReLU modules with nonzero baselines. Test Plan: - venv/uv/bin/python -m pytest -q tests/attr/test_deeplift_basic.py - Pyre: attempted `venv/uv/bin/pyre --noninteractive --dot-pyre-directory /tmp/captum-pyre-logs-config check`; blocked locally by broad pre-existing Pyre type-resolution failures resolving stdlib / torch imports. Differential Revision: D106053881 Pulled By: craymichael
meta-codesync
Bot
changed the title
craymichael
force-pushed
the
fix/1104-deeplift-adjacent-nonlinear
branch
from
29111e9 to
5ff6180
Compare
Contributor
|
@craymichael has exported this pull request. If you are a Meta employee, you can view the originating Diff in D106053881. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #1104.
Issue: #1104
Issue summary: adjacent supported nonlinear modules could use stale output gradients in DeepLift.
Test Plan:
venv/uv/bin/pyre --noninteractive --dot-pyre-directory /tmp/captum-pyre-logs-config check; blocked locally by broad pre-existing Pyre type-resolution failures resolving stdlib / torch imports.Differential Revision: D106053881
Pulled By: craymichael