Skip to content

Conversation

@saitcakmak
Copy link
Contributor

Summary:
Introduces a simple EnsembleMapSaasGP model that will replace get_fitted_map_saas_ensemble (which fits individual non-ensemble models and combines them into a fully Bayesian GP). The model internally is a batched ExactGP, which behaves just like a multi-output SingleTaskGP. The posterior method is overwritten to produce a MixtureGaussianPosterior, which retains the old behavior of the ensemble model.

The benefit of this model class is that it can be fit just like any other GP model, using ExactMarginalLogLikelihood and fit_gpytorch_mll. As such, it is fully compatible with Ax's MBM setup (as long as allow_batched_models=False).

Differential Revision: D83701925

@meta-cla meta-cla bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 2, 2025
@meta-codesync
Copy link

meta-codesync bot commented Oct 2, 2025

@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83701925.

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.98%. Comparing base (ce9cc6b) to head (a61ee05).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3035   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         216      216           
  Lines       20468    20504   +36     
=======================================
+ Hits        20464    20500   +36     
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Summary:

Introduces a simple `EnsembleMapSaasGP` model that will replace `get_fitted_map_saas_ensemble` (which fits individual non-ensemble models and combines them into a fully Bayesian GP). The model internally is a batched `ExactGP`, which behaves just like a multi-output `SingleTaskGP`. The `posterior` method is overwritten to produce a `MixtureGaussianPosterior`, which retains the old behavior of the ensemble model.

The benefit of this model class is that it can be fit just like any other GP model, using `ExactMarginalLogLikelihood` and `fit_gpytorch_mll`. As such, it is fully compatible with Ax's MBM setup (as long as `allow_batched_models=False`).

Reviewed By: sdaulton

Differential Revision: D83701925
saitcakmak added a commit to saitcakmak/botorch that referenced this pull request Oct 2, 2025
Summary:

Introduces a simple `EnsembleMapSaasGP` model that will replace `get_fitted_map_saas_ensemble` (which fits individual non-ensemble models and combines them into a fully Bayesian GP). The model internally is a batched `ExactGP`, which behaves just like a multi-output `SingleTaskGP`. The `posterior` method is overwritten to produce a `MixtureGaussianPosterior`, which retains the old behavior of the ensemble model.

The benefit of this model class is that it can be fit just like any other GP model, using `ExactMarginalLogLikelihood` and `fit_gpytorch_mll`. As such, it is fully compatible with Ax's MBM setup (as long as `allow_batched_models=False`).

Reviewed By: sdaulton

Differential Revision: D83701925
@meta-codesync meta-codesync bot closed this in 0650dcc Oct 2, 2025
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 0650dcc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants