condition_on_observations does not apply input transforms #2989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D80813693 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2989 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 216 216
Lines 20338 20339 +1
=========================================
+ Hits 20338 20339 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Aug 22, 2025
…ch#2989) Summary: Fixes OSS-reported issues in the interaction between condition_on_observations and input transforms, as input transforms are generally bypassed when using the method. Why bother? I personally seem to use this method for just about all my research, including the initialization work currently under review. Moreover, it can't be trialed in Ax without this fix. Differential Revision: D80813693
hvarfner
force-pushed
the
export-D80813693
branch
from
2075d3d to
21800ce
Compare
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Aug 22, 2025
…ch#2989) Summary: Fixes OSS-reported issues in the interaction between condition_on_observations and input transforms, as input transforms are generally bypassed when using the method. Why bother? I personally seem to use this method for just about all my research, including the initialization work currently under review. Moreover, it can't be trialed in Ax without this fix. Differential Revision: D80813693
|
This pull request was exported from Phabricator. Differential Revision: D80813693 |
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Aug 22, 2025
…ch#2989) Summary: Fixes OSS-reported issues in the interaction between condition_on_observations and input transforms, as input transforms are generally bypassed when using the method. Why bother? I personally seem to use this method for just about all my research, including the initialization work currently under review. Moreover, it can't be trialed in Ax without this fix. Differential Revision: D80813693
hvarfner
force-pushed
the
export-D80813693
branch
from
21800ce to
e308339
Compare
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Aug 22, 2025
…ch#2989) Summary: Fixes OSS-reported issues in the interaction between condition_on_observations and input transforms, as input transforms are generally bypassed when using the method. Why bother? I personally seem to use this method for just about all my research, including the initialization work currently under review. Moreover, it can't be trialed in Ax without this fix. Differential Revision: D80813693
|
This pull request was exported from Phabricator. Differential Revision: D80813693 |
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Aug 22, 2025
…ch#2989) Summary: Pull Request resolved: meta-pytorch#2989 Fixes OSS-reported issues in the interaction between condition_on_observations and input transforms, as input transforms are generally bypassed when using the method. Why bother? I personally seem to use this method for just about all my research, including the initialization work currently under review. Moreover, it can't be trialed in Ax without this fix. Differential Revision: D80813693
hvarfner
force-pushed
the
export-D80813693
branch
2 times, most recently
from
8979c16 to
a12f792
Compare
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Aug 25, 2025
…ch#2989) Summary: Fixes OSS-reported issues in the interaction between condition_on_observations and input transforms, as input transforms are generally bypassed when using the method. Why bother? I personally seem to use this method for just about all my research, including the initialization work currently under review. Moreover, it can't be trialed in Ax without this fix. Differential Revision: D80813693
|
This pull request was exported from Phabricator. Differential Revision: D80813693 |
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Aug 25, 2025
…ch#2989) Summary: Fixes OSS-reported issues in the interaction between condition_on_observations and input transforms, as input transforms are generally bypassed when using the method. Why bother? I personally seem to use this method for just about all my research, including the initialization work currently under review. Moreover, it can't be trialed in Ax without this fix. Differential Revision: D80813693
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Aug 25, 2025
…ch#2989) Summary: Fixes OSS-reported issues in the interaction between condition_on_observations and input transforms, as input transforms are generally bypassed when using the method. Why bother? I personally seem to use this method for just about all my research, including the initialization work currently under review. Moreover, it can't be trialed in Ax without this fix. Differential Revision: D80813693
hvarfner
force-pushed
the
export-D80813693
branch
from
a12f792 to
5861d26
Compare
|
This pull request was exported from Phabricator. Differential Revision: D80813693 |
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Aug 25, 2025
…ch#2989) Summary: Fixes OSS-reported issues in the interaction between condition_on_observations and input transforms, as input transforms are generally bypassed when using the method. Why bother? I personally seem to use this method for just about all my research, including the initialization work currently under review. Moreover, it can't be trialed in Ax without this fix. Differential Revision: D80813693
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Aug 25, 2025
…ch#2989) Summary: Pull Request resolved: meta-pytorch#2989 Fixes OSS-reported issues in the interaction between condition_on_observations and input transforms, as input transforms are generally bypassed when using the method. Why bother? I personally seem to use this method for just about all my research, including the initialization work currently under review. Moreover, it can't be trialed in Ax without this fix. Differential Revision: D80813693
|
This pull request was exported from Phabricator. Differential Revision: D80813693 |
hvarfner
force-pushed
the
export-D80813693
branch
from
5861d26 to
bdfc0c5
Compare
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Aug 25, 2025
…ch#2989) Summary: Pull Request resolved: meta-pytorch#2989 Fixes OSS-reported issues in the interaction between condition_on_observations and input transforms, as input transforms are generally bypassed when using the method. Why bother? I personally seem to use this method for just about all my research, including the initialization work currently under review. Moreover, it can't be trialed in Ax without this fix. Differential Revision: D80813693
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Aug 25, 2025
…ch#2989) Summary: Fixes OSS-reported issues in the interaction between condition_on_observations and input transforms, as input transforms are generally bypassed when using the method. Why bother? I personally seem to use this method for just about all my research, including the initialization work currently under review. Moreover, it can't be trialed in Ax without this fix. Differential Revision: D80813693
…ch#2989) Summary: Fixes OSS-reported issues in the interaction between condition_on_observations and input transforms, as input transforms are generally bypassed when using the method. Why bother? I personally seem to use this method for just about all my research, including the initialization work currently under review. Moreover, it can't be trialed in Ax without this fix. Differential Revision: D80813693
hvarfner
force-pushed
the
export-D80813693
branch
from
bdfc0c5 to
e05a40a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D80813693 |
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Aug 26, 2025
…ch#2989) Summary: Fixes OSS-reported issues in the interaction between condition_on_observations and input transforms, as input transforms are generally bypassed when using the method. Why bother? I personally seem to use this method for just about all my research, including the initialization work currently under review. Moreover, it can't be trialed in Ax without this fix. Differential Revision: D80813693
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Aug 28, 2025
…ch#2989) Summary: Fixes OSS-reported issues in the interaction between condition_on_observations and input transforms, as input transforms are generally bypassed when using the method. Why bother? I personally seem to use this method for just about all my research, including the initialization work currently under review. Moreover, it can't be trialed in Ax without this fix. Reviewed By: saitcakmak Differential Revision: D80813693
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Aug 28, 2025
…ch#2989) Summary: Pull Request resolved: meta-pytorch#2989 Fixes OSS-reported issues in the interaction between condition_on_observations and input transforms, as input transforms are generally bypassed when using the method. Why bother? I personally seem to use this method for just about all my research, including the initialization work currently under review. Moreover, it can't be trialed in Ax without this fix. Differential Revision: D80813693
|
This pull request has been merged in e3710e2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes OSS-reported issues in the interaction between condition_on_observations and input transforms, as input transforms are generally bypassed when using the method.
Moreover, it can't be trialed in Ax without this fix.
Differential Revision: D80813693