- 
                Notifications
    
You must be signed in to change notification settings  - Fork 451
 
Add support for missing tasks in mtgp #2960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           This pull request was exported from Phabricator. Differential Revision: D79812024  | 
    
Summary: X-link: meta-pytorch/botorch#2960 Currently, cross-validation in Ax fails when using a MTGP if there are multiple metrics and only some metrics have been observed for some tasks. This is a modeling problem, since the model is a ModelListGP and not all MTGPs in the list are required to have the same tasks. Hence when you pass in a test input, the model errors out if there are not observations from that task in the training data. This avoids the error by mapping (optionally) mapping unexpected tasks to the "target task". This does not change the default behavior. For cross-validation in Ax, predictions are discarded if there are no observations for a given (task, metric) pair. This will still error out in Ax if data for the target trial is missing. Differential Revision: D79812024
          Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@            Coverage Diff            @@
##              main     #2960   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          216       216           
  Lines        20328     20338   +10     
=========================================
+ Hits         20328     20338   +10     ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
  | 
    
Summary: X-link: meta-pytorch/botorch#2960 Currently, cross-validation in Ax fails when using a MTGP if there are multiple metrics and only some metrics have been observed for some tasks. This is a modeling problem, since the model is a ModelListGP and not all MTGPs in the list are required to have the same tasks. Hence when you pass in a test input, the model errors out if there are not observations from that task in the training data. This avoids the error by mapping (optionally) mapping unexpected tasks to the "target task". This does not change the default behavior. For cross-validation in Ax, predictions are discarded if there are no observations for a given (task, metric) pair. This will still error out in Ax if data for the target trial is missing. Differential Revision: D79812024
Summary: X-link: facebook/Ax#4121 Currently, cross-validation in Ax fails when using a MTGP if there are multiple metrics and only some metrics have been observed for some tasks. This is a modeling problem, since the model is a ModelListGP and not all MTGPs in the list are required to have the same tasks. Hence when you pass in a test input, the model errors out if there are not observations from that task in the training data. This avoids the error by mapping (optionally) mapping unexpected tasks to the "target task". This does not change the default behavior. For cross-validation in Ax, predictions are discarded if there are no observations for a given (task, metric) pair. This will still error out in Ax if data for the target trial is missing. Differential Revision: D79812024
f03dda4    to
    fae6912      
    Compare
  
    | 
           This pull request was exported from Phabricator. Differential Revision: D79812024  | 
    
Summary: X-link: facebook/Ax#4121 Pull Request resolved: meta-pytorch#2960 Currently, cross-validation in Ax fails when using a MTGP if there are multiple metrics and only some metrics have been observed for some tasks. This is a modeling problem, since the model is a ModelListGP and not all MTGPs in the list are required to have the same tasks. Hence when you pass in a test input, the model errors out if there are not observations from that task in the training data. This avoids the error by mapping (optionally) mapping unexpected tasks to the "target task". This does not change the default behavior. For cross-validation in Ax, predictions are discarded if there are no observations for a given (task, metric) pair. This will still error out in Ax if data for the target trial is missing. Differential Revision: D79812024
fae6912    to
    3ad186d      
    Compare
  
    Summary: Pull Request resolved: facebook#4121 X-link: meta-pytorch/botorch#2960 Currently, cross-validation in Ax fails when using a MTGP if there are multiple metrics and only some metrics have been observed for some tasks. This is a modeling problem, since the model is a ModelListGP and not all MTGPs in the list are required to have the same tasks. Hence when you pass in a test input, the model errors out if there are not observations from that task in the training data. This avoids the error by mapping (optionally) mapping unexpected tasks to the "target task". This does not change the default behavior. For cross-validation in Ax, predictions are discarded if there are no observations for a given (task, metric) pair. This will still error out in Ax if data for the target trial is missing. Differential Revision: D79812024
Summary: X-link: meta-pytorch/botorch#2960 Currently, cross-validation in Ax fails when using a MTGP if there are multiple metrics and only some metrics have been observed for some tasks. This is a modeling problem, since the model is a ModelListGP and not all MTGPs in the list are required to have the same tasks. Hence when you pass in a test input, the model errors out if there are not observations from that task in the training data. This avoids the error by mapping (optionally) mapping unexpected tasks to the "target task". This does not change the default behavior. For cross-validation in Ax, predictions are discarded if there are no observations for a given (task, metric) pair. This will still error out in Ax if data for the target trial is missing. Differential Revision: D79812024
Summary: X-link: facebook/Ax#4121 Currently, cross-validation in Ax fails when using a MTGP if there are multiple metrics and only some metrics have been observed for some tasks. This is a modeling problem, since the model is a ModelListGP and not all MTGPs in the list are required to have the same tasks. Hence when you pass in a test input, the model errors out if there are not observations from that task in the training data. This avoids the error by mapping (optionally) mapping unexpected tasks to the "target task". This does not change the default behavior. For cross-validation in Ax, predictions are discarded if there are no observations for a given (task, metric) pair. This will still error out in Ax if data for the target trial is missing. Differential Revision: D79812024
3ad186d    to
    5ef3c77      
    Compare
  
    | 
           This pull request was exported from Phabricator. Differential Revision: D79812024  | 
    
Summary: X-link: facebook/Ax#4121 Currently, cross-validation in Ax fails when using a MTGP if there are multiple metrics and only some metrics have been observed for some tasks. This is a modeling problem, since the model is a ModelListGP and not all MTGPs in the list are required to have the same tasks. Hence when you pass in a test input, the model errors out if there are not observations from that task in the training data. This avoids the error by mapping (optionally) mapping unexpected tasks to the "target task". This does not change the default behavior. For cross-validation in Ax, predictions are discarded if there are no observations for a given (task, metric) pair. This will still error out in Ax if data for the target trial is missing. Differential Revision: D79812024
5ef3c77    to
    023b232      
    Compare
  
    | 
           This pull request was exported from Phabricator. Differential Revision: D79812024  | 
    
Summary: X-link: meta-pytorch/botorch#2960 Currently, cross-validation in Ax fails when using a MTGP if there are multiple metrics and only some metrics have been observed for some tasks. This is a modeling problem, since the model is a ModelListGP and not all MTGPs in the list are required to have the same tasks. Hence when you pass in a test input, the model errors out if there are not observations from that task in the training data. This avoids the error by mapping (optionally) mapping unexpected tasks to the "target task". This does not change the default behavior. For cross-validation in Ax, predictions are discarded if there are no observations for a given (task, metric) pair. This will still error out in Ax if data for the target trial is missing. Differential Revision: D79812024
Summary: X-link: meta-pytorch/botorch#2960 Currently, cross-validation in Ax fails when using a MTGP if there are multiple metrics and only some metrics have been observed for some tasks. This is a modeling problem, since the model is a ModelListGP and not all MTGPs in the list are required to have the same tasks. Hence when you pass in a test input, the model errors out if there are not observations from that task in the training data. This avoids the error by mapping (optionally) mapping unexpected tasks to the "target task". This does not change the default behavior. For cross-validation in Ax, predictions are discarded if there are no observations for a given (task, metric) pair. This will still error out in Ax if data for the target trial is missing. Differential Revision: D79812024
Summary: X-link: facebook/Ax#4121 Currently, cross-validation in Ax fails when using a MTGP if there are multiple metrics and only some metrics have been observed for some tasks. This is a modeling problem, since the model is a ModelListGP and not all MTGPs in the list are required to have the same tasks. Hence when you pass in a test input, the model errors out if there are not observations from that task in the training data. This avoids the error by mapping (optionally) mapping unexpected tasks to the "target task". This does not change the default behavior. For cross-validation in Ax, predictions are discarded if there are no observations for a given (task, metric) pair. This will still error out in Ax if data for the target trial is missing. Differential Revision: D79812024
023b232    to
    6c977ee      
    Compare
  
    | 
           This pull request was exported from Phabricator. Differential Revision: D79812024  | 
    
Summary: X-link: meta-pytorch/botorch#2960 Currently, cross-validation in Ax fails when using a MTGP if there are multiple metrics and only some metrics have been observed for some tasks. This is a modeling problem, since the model is a ModelListGP and not all MTGPs in the list are required to have the same tasks. Hence when you pass in a test input, the model errors out if there are not observations from that task in the training data. This avoids the error by mapping (optionally) mapping unexpected tasks to the "target task". This does not change the default behavior. For cross-validation in Ax, predictions are discarded if there are no observations for a given (task, metric) pair. This will still error out in Ax if data for the target trial is missing. Differential Revision: D79812024
Summary: X-link: meta-pytorch/botorch#2960 Currently, cross-validation in Ax fails when using a MTGP if there are multiple metrics and only some metrics have been observed for some tasks. This is a modeling problem, since the model is a ModelListGP and not all MTGPs in the list are required to have the same tasks. Hence when you pass in a test input, the model errors out if there are not observations from that task in the training data. This avoids the error by mapping (optionally) mapping unexpected tasks to the "target task". This does not change the default behavior. For cross-validation in Ax, predictions are discarded if there are no observations for a given (task, metric) pair. This will still error out in Ax if data for the target trial is missing. Differential Revision: D79812024
Summary: X-link: facebook/Ax#4121 Currently, cross-validation in Ax fails when using a MTGP if there are multiple metrics and only some metrics have been observed for some tasks. This is a modeling problem, since the model is a ModelListGP and not all MTGPs in the list are required to have the same tasks. Hence when you pass in a test input, the model errors out if there are not observations from that task in the training data. This avoids the error by mapping (optionally) mapping unexpected tasks to the "target task". This does not change the default behavior. For cross-validation in Ax, predictions are discarded if there are no observations for a given (task, metric) pair. This will still error out in Ax if data for the target trial is missing. Differential Revision: D79812024
6c977ee    to
    fc0e7fd      
    Compare
  
    Summary: X-link: facebook/Ax#4121 Currently, cross-validation in Ax fails when using a MTGP if there are multiple metrics and only some metrics have been observed for some tasks. This is a modeling problem, since the model is a ModelListGP and not all MTGPs in the list are required to have the same tasks. Hence when you pass in a test input, the model errors out if there are not observations from that task in the training data. This avoids the error by mapping (optionally) mapping unexpected tasks to the "target task". This does not change the default behavior. For cross-validation in Ax, predictions are discarded if there are no observations for a given (task, metric) pair. This will still error out in Ax if data for the target trial is missing. Differential Revision: D79812024
| 
           This pull request was exported from Phabricator. Differential Revision: D79812024  | 
    
Summary: X-link: facebookexternal/botorch_fb#24 X-link: facebook/Ax#4121 Pull Request resolved: meta-pytorch#2960 Currently, cross-validation in Ax fails when using a MTGP if there are multiple metrics and only some metrics have been observed for some tasks. This is a modeling problem, since the model is a ModelListGP and not all MTGPs in the list are required to have the same tasks. Hence when you pass in a test input, the model errors out if there are not observations from that task in the training data. This avoids the error by mapping (optionally) mapping unexpected tasks to the "target task". This does not change the default behavior. For cross-validation in Ax, predictions are discarded if there are no observations for a given (task, metric) pair. This will still error out in Ax if data for the target trial is missing. Differential Revision: D79812024
589ff95    to
    b51fc3c      
    Compare
  
    Summary: X-link: facebookexternal/botorch_fb#24 Pull Request resolved: facebook#4121 X-link: meta-pytorch/botorch#2960 Currently, cross-validation in Ax fails when using a MTGP if there are multiple metrics and only some metrics have been observed for some tasks. This is a modeling problem, since the model is a ModelListGP and not all MTGPs in the list are required to have the same tasks. Hence when you pass in a test input, the model errors out if there are not observations from that task in the training data. This avoids the error by mapping (optionally) mapping unexpected tasks to the "target task". This does not change the default behavior. For cross-validation in Ax, predictions are discarded if there are no observations for a given (task, metric) pair. This will still error out in Ax if data for the target trial is missing. Differential Revision: D79812024
Summary: X-link: facebookexternal/botorch_fb#24 X-link: meta-pytorch/botorch#2960 Currently, cross-validation in Ax fails when using a MTGP if there are multiple metrics and only some metrics have been observed for some tasks. This is a modeling problem, since the model is a ModelListGP and not all MTGPs in the list are required to have the same tasks. Hence when you pass in a test input, the model errors out if there are not observations from that task in the training data. This avoids the error by mapping (optionally) mapping unexpected tasks to the "target task". This does not change the default behavior. For cross-validation in Ax, predictions are discarded if there are no observations for a given (task, metric) pair. This will still error out in Ax if data for the target trial is missing. Differential Revision: D79812024
Summary: X-link: facebookexternal/botorch_fb#24 X-link: facebook/Ax#4121 Currently, cross-validation in Ax fails when using a MTGP if there are multiple metrics and only some metrics have been observed for some tasks. This is a modeling problem, since the model is a ModelListGP and not all MTGPs in the list are required to have the same tasks. Hence when you pass in a test input, the model errors out if there are not observations from that task in the training data. This avoids the error by mapping (optionally) mapping unexpected tasks to the "target task". This does not change the default behavior. For cross-validation in Ax, predictions are discarded if there are no observations for a given (task, metric) pair. This will still error out in Ax if data for the target trial is missing. Differential Revision: D79812024
b51fc3c    to
    2470005      
    Compare
  
    | 
           This pull request was exported from Phabricator. Differential Revision: D79812024  | 
    
Summary: X-link: facebookexternal/botorch_fb#24 X-link: meta-pytorch/botorch#2960 Currently, cross-validation in Ax fails when using a MTGP if there are multiple metrics and only some metrics have been observed for some tasks. This is a modeling problem, since the model is a ModelListGP and not all MTGPs in the list are required to have the same tasks. Hence when you pass in a test input, the model errors out if there are not observations from that task in the training data. This avoids the error by mapping (optionally) mapping unexpected tasks to the "target task". This does not change the default behavior. For cross-validation in Ax, predictions are discarded if there are no observations for a given (task, metric) pair. This will still error out in Ax if data for the target trial is missing. Reviewed By: ItsMrLin Differential Revision: D79812024
2470005    to
    e047ee5      
    Compare
  
    Summary: X-link: facebookexternal/botorch_fb#24 X-link: facebook/Ax#4121 Currently, cross-validation in Ax fails when using a MTGP if there are multiple metrics and only some metrics have been observed for some tasks. This is a modeling problem, since the model is a ModelListGP and not all MTGPs in the list are required to have the same tasks. Hence when you pass in a test input, the model errors out if there are not observations from that task in the training data. This avoids the error by mapping (optionally) mapping unexpected tasks to the "target task". This does not change the default behavior. For cross-validation in Ax, predictions are discarded if there are no observations for a given (task, metric) pair. This will still error out in Ax if data for the target trial is missing. Reviewed By: ItsMrLin Differential Revision: D79812024
| 
           This pull request was exported from Phabricator. Differential Revision: D79812024  | 
    
Summary: X-link: facebookexternal/botorch_fb#24 X-link: meta-pytorch/botorch#2960 Currently, cross-validation in Ax fails when using a MTGP if there are multiple metrics and only some metrics have been observed for some tasks. This is a modeling problem, since the model is a ModelListGP and not all MTGPs in the list are required to have the same tasks. Hence when you pass in a test input, the model errors out if there are not observations from that task in the training data. This avoids the error by mapping (optionally) mapping unexpected tasks to the "target task". This does not change the default behavior. For cross-validation in Ax, predictions are discarded if there are no observations for a given (task, metric) pair. This will still error out in Ax if data for the target trial is missing. Reviewed By: ItsMrLin Differential Revision: D79812024
e047ee5    to
    f0beefb      
    Compare
  
    Summary: X-link: facebookexternal/botorch_fb#24 X-link: facebook/Ax#4121 Currently, cross-validation in Ax fails when using a MTGP if there are multiple metrics and only some metrics have been observed for some tasks. This is a modeling problem, since the model is a ModelListGP and not all MTGPs in the list are required to have the same tasks. Hence when you pass in a test input, the model errors out if there are not observations from that task in the training data. This avoids the error by mapping (optionally) mapping unexpected tasks to the "target task". This does not change the default behavior. For cross-validation in Ax, predictions are discarded if there are no observations for a given (task, metric) pair. This will still error out in Ax if data for the target trial is missing. Reviewed By: ItsMrLin Differential Revision: D79812024
| 
           This pull request was exported from Phabricator. Differential Revision: D79812024  | 
    
f0beefb    to
    63a0f64      
    Compare
  
    Summary: X-link: facebookexternal/botorch_fb#24 X-link: facebook/Ax#4121 Currently, cross-validation in Ax fails when using a MTGP if there are multiple metrics and only some metrics have been observed for some tasks. This is a modeling problem, since the model is a ModelListGP and not all MTGPs in the list are required to have the same tasks. Hence when you pass in a test input, the model errors out if there are not observations from that task in the training data. This avoids the error by mapping (optionally) mapping unexpected tasks to the "target task". This does not change the default behavior. For cross-validation in Ax, predictions are discarded if there are no observations for a given (task, metric) pair. This will still error out in Ax if data for the target trial is missing. Reviewed By: ItsMrLin Differential Revision: D79812024
Summary: X-link: facebookexternal/botorch_fb#24 X-link: meta-pytorch/botorch#2960 Currently, cross-validation in Ax fails when using a MTGP if there are multiple metrics and only some metrics have been observed for some tasks. This is a modeling problem, since the model is a ModelListGP and not all MTGPs in the list are required to have the same tasks. Hence when you pass in a test input, the model errors out if there are not observations from that task in the training data. This avoids the error by mapping (optionally) mapping unexpected tasks to the "target task". This does not change the default behavior. For cross-validation in Ax, predictions are discarded if there are no observations for a given (task, metric) pair. This will still error out in Ax if data for the target trial is missing. Reviewed By: ItsMrLin Differential Revision: D79812024
Summary: X-link: facebookexternal/botorch_fb#24 X-link: facebook/Ax#4121 Pull Request resolved: meta-pytorch#2960 Currently, cross-validation in Ax fails when using a MTGP if there are multiple metrics and only some metrics have been observed for some tasks. This is a modeling problem, since the model is a ModelListGP and not all MTGPs in the list are required to have the same tasks. Hence when you pass in a test input, the model errors out if there are not observations from that task in the training data. This avoids the error by mapping (optionally) mapping unexpected tasks to the "target task". This does not change the default behavior. For cross-validation in Ax, predictions are discarded if there are no observations for a given (task, metric) pair. This will still error out in Ax if data for the target trial is missing. Reviewed By: ItsMrLin Differential Revision: D79812024
| 
           This pull request was exported from Phabricator. Differential Revision: D79812024  | 
    
63a0f64    to
    33aceb7      
    Compare
  
    Summary: X-link: facebookexternal/botorch_fb#24 Pull Request resolved: facebook#4121 X-link: meta-pytorch/botorch#2960 Currently, cross-validation in Ax fails when using a MTGP if there are multiple metrics and only some metrics have been observed for some tasks. This is a modeling problem, since the model is a ModelListGP and not all MTGPs in the list are required to have the same tasks. Hence when you pass in a test input, the model errors out if there are not observations from that task in the training data. This avoids the error by mapping (optionally) mapping unexpected tasks to the "target task". This does not change the default behavior. For cross-validation in Ax, predictions are discarded if there are no observations for a given (task, metric) pair. This will still error out in Ax if data for the target trial is missing. Reviewed By: ItsMrLin Differential Revision: D79812024
Summary: X-link: facebookexternal/botorch_fb#24 Pull Request resolved: #4121 X-link: meta-pytorch/botorch#2960 Currently, cross-validation in Ax fails when using a MTGP if there are multiple metrics and only some metrics have been observed for some tasks. This is a modeling problem, since the model is a ModelListGP and not all MTGPs in the list are required to have the same tasks. Hence when you pass in a test input, the model errors out if there are not observations from that task in the training data. This avoids the error by mapping (optionally) mapping unexpected tasks to the "target task". This does not change the default behavior. For cross-validation in Ax, predictions are discarded if there are no observations for a given (task, metric) pair. This will still error out in Ax if data for the target trial is missing. Reviewed By: ItsMrLin Differential Revision: D79812024 fbshipit-source-id: f92a49fb46222698fdea13b5d96841bf2d5d679b
| 
           This pull request has been merged in 9058a77.  | 
    
| 
           This pull request has been reverted by 3135a7b.  | 
    
Summary:
Currently, cross-validation in Ax fails when using a MTGP if there are multiple metrics and only some metrics have been observed for some tasks. This is a modeling problem, since the model is a ModelListGP and not all MTGPs in the list are required to have the same tasks. Hence when you pass in a test input, the model errors out if there are not observations from that task in the training data.
This avoids the error by mapping (optionally) mapping unexpected tasks to the "target task". This does not change the default behavior. For cross-validation in Ax, predictions are discarded if there are no observations for a given (task, metric) pair.
This will still error out in Ax if data for the target trial is missing.
Differential Revision: D79812024