fix input constructor for LogProbabilityOfFeasibility #2945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D79281274 |
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Jul 30, 2025
Summary: X-link: meta-pytorch/botorch#2945 Constraints were being passed in the wrong format (a list of callables rather than a dictionary of indices to bounds). This also removes `convert_to_target_pre_hook`, which only works for args and doesn't work for kwargs. Previously `LogProbabilityOfFeasibility` would error out if called with a kwarg---e.g. `acqf(X=X)` dtype and device are set in `_mean_and_sigma` for these AFs anyway. Reviewed By: SebastianAment Differential Revision: D79281274
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Jul 30, 2025
Summary: X-link: meta-pytorch/botorch#2945 Constraints were being passed in the wrong format (a list of callables rather than a dictionary of indices to bounds). This also removes `convert_to_target_pre_hook`, which only works for args and doesn't work for kwargs. Previously `LogProbabilityOfFeasibility` would error out if called with a kwarg---e.g. `acqf(X=X)` dtype and device are set in `_mean_and_sigma` for these AFs anyway. Reviewed By: SebastianAment Differential Revision: D79281274
sdaulton
added a commit
to sdaulton/botorch
that referenced
this pull request
Jul 30, 2025
) Summary: X-link: facebook/Ax#4080 Constraints were being passed in the wrong format (a list of callables rather than a dictionary of indices to bounds). This also removes `convert_to_target_pre_hook`, which only works for args and doesn't work for kwargs. Previously `LogProbabilityOfFeasibility` would error out if called with a kwarg---e.g. `acqf(X=X)` dtype and device are set in `_mean_and_sigma` for these AFs anyway. Reviewed By: SebastianAment Differential Revision: D79281274
sdaulton
force-pushed
the
export-D79281274
branch
from
06b6ed0 to
d533622
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79281274 |
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Jul 30, 2025
Summary: X-link: meta-pytorch/botorch#2945 Constraints were being passed in the wrong format (a list of callables rather than a dictionary of indices to bounds). This also removes `convert_to_target_pre_hook`, which only works for args and doesn't work for kwargs. Previously `LogProbabilityOfFeasibility` would error out if called with a kwarg---e.g. `acqf(X=X)` dtype and device are set in `_mean_and_sigma` for these AFs anyway. Reviewed By: SebastianAment Differential Revision: D79281274
) Summary: X-link: facebook/Ax#4080 Constraints were being passed in the wrong format (a list of callables rather than a dictionary of indices to bounds). This also removes `convert_to_target_pre_hook`, which only works for args and doesn't work for kwargs. Previously `LogProbabilityOfFeasibility` would error out if called with a kwarg---e.g. `acqf(X=X)` dtype and device are set in `_mean_and_sigma` for these AFs anyway. Reviewed By: SebastianAment Differential Revision: D79281274
sdaulton
force-pushed
the
export-D79281274
branch
from
d533622 to
fbd4500
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79281274 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2945 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 216 216
Lines 20225 20232 +7
=========================================
+ Hits 20225 20232 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Jul 30, 2025
Summary: X-link: meta-pytorch/botorch#2945 Constraints were being passed in the wrong format (a list of callables rather than a dictionary of indices to bounds). This also removes `convert_to_target_pre_hook`, which only works for args and doesn't work for kwargs. Previously `LogProbabilityOfFeasibility` would error out if called with a kwarg---e.g. `acqf(X=X)` dtype and device are set in `_mean_and_sigma` for these AFs anyway. Reviewed By: SebastianAment Differential Revision: D79281274
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Jul 30, 2025
Summary: X-link: meta-pytorch/botorch#2945 Constraints were being passed in the wrong format (a list of callables rather than a dictionary of indices to bounds). This also removes `convert_to_target_pre_hook`, which only works for args and doesn't work for kwargs. Previously `LogProbabilityOfFeasibility` would error out if called with a kwarg---e.g. `acqf(X=X)` dtype and device are set in `_mean_and_sigma` for these AFs anyway. Reviewed By: SebastianAment Differential Revision: D79281274
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Jul 30, 2025
Summary: X-link: meta-pytorch/botorch#2945 Constraints were being passed in the wrong format (a list of callables rather than a dictionary of indices to bounds). This also removes `convert_to_target_pre_hook`, which only works for args and doesn't work for kwargs. Previously `LogProbabilityOfFeasibility` would error out if called with a kwarg---e.g. `acqf(X=X)` dtype and device are set in `_mean_and_sigma` for these AFs anyway. Reviewed By: SebastianAment Differential Revision: D79281274
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Jul 30, 2025
Summary: X-link: meta-pytorch/botorch#2945 Constraints were being passed in the wrong format (a list of callables rather than a dictionary of indices to bounds). This also removes `convert_to_target_pre_hook`, which only works for args and doesn't work for kwargs. Previously `LogProbabilityOfFeasibility` would error out if called with a kwarg---e.g. `acqf(X=X)` dtype and device are set in `_mean_and_sigma` for these AFs anyway. Reviewed By: SebastianAment Differential Revision: D79281274
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Jul 30, 2025
Summary: X-link: meta-pytorch/botorch#2945 Constraints were being passed in the wrong format (a list of callables rather than a dictionary of indices to bounds). This also removes `convert_to_target_pre_hook`, which only works for args and doesn't work for kwargs. Previously `LogProbabilityOfFeasibility` would error out if called with a kwarg---e.g. `acqf(X=X)` dtype and device are set in `_mean_and_sigma` for these AFs anyway. Reviewed By: SebastianAment Differential Revision: D79281274
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Jul 30, 2025
Summary: X-link: meta-pytorch/botorch#2945 Constraints were being passed in the wrong format (a list of callables rather than a dictionary of indices to bounds). This also removes `convert_to_target_pre_hook`, which only works for args and doesn't work for kwargs. Previously `LogProbabilityOfFeasibility` would error out if called with a kwarg---e.g. `acqf(X=X)` dtype and device are set in `_mean_and_sigma` for these AFs anyway. Reviewed By: SebastianAment Differential Revision: D79281274
|
This pull request has been merged in 1ee3a86. |
facebook-github-bot
pushed a commit
to facebook/Ax
that referenced
this pull request
Jul 31, 2025
Summary: X-link: meta-pytorch/botorch#2945 Pull Request resolved: #4080 Constraints were being passed in the wrong format (a list of callables rather than a dictionary of indices to bounds). This also removes `convert_to_target_pre_hook`, which only works for args and doesn't work for kwargs. Previously `LogProbabilityOfFeasibility` would error out if called with a kwarg---e.g. `acqf(X=X)` dtype and device are set in `_mean_and_sigma` for these AFs anyway. Reviewed By: SebastianAment Differential Revision: D79281274 fbshipit-source-id: ad4d7b5dc524f80c8151c11f8d6f2921aa9ea5db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/Ax#4080
Constraints were being passed in the wrong format (a list of callables rather than a dictionary of indices to bounds).
This also removes
convert_to_target_pre_hook, which only works for args and doesn't work for kwargs. PreviouslyLogProbabilityOfFeasibilitywould error out if called with a kwarg---e.g.acqf(X=X)dtype and device are set in_mean_and_sigmafor these AFs anyway.Differential Revision: D79281274