Eliminate expensive indexing in separate_mtmvn #2920
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fixes meta-pytorch#2919 The batched indexing of the covariance tensor was consuming extraordinary amounts of memory, enough to crash servers with moderately sized tensors. Profiling `separate_mtmvn` with `n_test=64` (256 was crashing my server) using the repro from the above issue. Before: Using >7GB ram and taking >800ms {F1980143884} After: Using ~5e-5 GB ram and taking ~20ms {F1980143899} Differential Revision: D78038356
|
This pull request was exported from Phabricator. Differential Revision: D78038356 |
facebook-github-bot
added
CLA Signed
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2920 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 212 212
Lines 19819 19817 -2
=========================================
- Hits 19819 19817 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in 71f03ea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #2919
The batched indexing of the covariance tensor was consuming extraordinary amounts of memory, enough to crash servers with moderately sized tensors.
Profiling
separate_mtmvnwithn_test=64(256 was crashing my server) using the repro from the above issue.Before: Using >7GB ram and taking >800ms
{F1980143884}
After: Using ~5e-5 GB ram and taking ~20ms
{F1980143899}
Differential Revision: D78038356