Performance & runtime improvements to info-theoretic acquisition functions (0/N) - Restructuring of sampling methods #2753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
hvarfner
force-pushed
the
sample_restructure
branch
2 times, most recently
from
4dbe092 to
14eddf6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2753 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 203 203
Lines 18692 18685 -7
=======================================
- Hits 18691 18684 -7
Misses 1 1 ☔ View full report in Codecov by Sentry. |
esantorella
reviewed
Feb 24, 2025
| replacement: bool = False, | ||
| temp_decrease: float = 0.5, | ||
| ): | ||
| """ |
There was a problem hiding this comment.
Thanks so much for the clear docstring!
esantorella
reviewed
Feb 24, 2025
saitcakmak
approved these changes
Feb 24, 2025
|
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
saitcakmak
reviewed
Feb 24, 2025
saitcakmak
reviewed
Feb 24, 2025
|
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
code, reshuffling of other sampling methods (that don't take an acqf)
Co-authored-by: Elizabeth Santorella <elizabeth.santorella@gmail.com>
hvarfner
force-pushed
the
sample_restructure
branch
from
fd338fb to
6995223
Compare
|
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@saitcakmak merged this pull request in 78c04e2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reshuffling of sampling methods that are not directly related to acquisition function optimization (i.e., don't take it as an argument) based on this discussion. To remove code duplication specifically related to optimization of info-theoretic acquisition functions, this seemed like sensible moves!
Test Plan
Moved unittests and added new one for
boltzmann_sample, which was used throughout and is once again used in subsequent PRs.Related PRs
First of a series, like this one.