introduce trial_indices argument to SupervisedDataset #2595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64764019 |
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
Oct 25, 2024
Summary: X-link: meta-pytorch/botorch#2595 Adds optional `trial_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)). Reviewed By: Balandat Differential Revision: D64764019
bernardbeckerman
added a commit
to bernardbeckerman/botorch
that referenced
this pull request
Oct 25, 2024
) Summary: X-link: facebook/Ax#2960 Adds optional `trial_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)). Reviewed By: Balandat Differential Revision: D64764019
bernardbeckerman
force-pushed
the
export-D64764019
branch
from
71bbca9 to
932c56f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64764019 |
bernardbeckerman
added a commit
to bernardbeckerman/botorch
that referenced
this pull request
Oct 25, 2024
) Summary: X-link: facebook/Ax#2960 Adds optional `trial_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)). Reviewed By: Balandat Differential Revision: D64764019
bernardbeckerman
force-pushed
the
export-D64764019
branch
from
932c56f to
7f05f05
Compare
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
Oct 25, 2024
Summary: X-link: meta-pytorch/botorch#2595 Adds optional `trial_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)). Reviewed By: Balandat Differential Revision: D64764019
|
This pull request was exported from Phabricator. Differential Revision: D64764019 |
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
Oct 25, 2024
Summary: X-link: meta-pytorch/botorch#2595 Adds optional `trial_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)). Reviewed By: Balandat Differential Revision: D64764019
bernardbeckerman
added a commit
to bernardbeckerman/botorch
that referenced
this pull request
Oct 25, 2024
) Summary: X-link: facebook/Ax#2960 Adds optional `trial_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)). Reviewed By: Balandat Differential Revision: D64764019
bernardbeckerman
force-pushed
the
export-D64764019
branch
from
7f05f05 to
2b4054d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64764019 |
bernardbeckerman
added a commit
to bernardbeckerman/botorch
that referenced
this pull request
Oct 25, 2024
) Summary: X-link: facebook/Ax#2960 Adds optional `trial_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)). Reviewed By: Balandat Differential Revision: D64764019
bernardbeckerman
force-pushed
the
export-D64764019
branch
from
2b4054d to
40b2899
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64764019 |
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
Oct 25, 2024
Summary: X-link: meta-pytorch/botorch#2595 Adds optional `trial_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)). Reviewed By: Balandat Differential Revision: D64764019
bernardbeckerman
force-pushed
the
export-D64764019
branch
from
40b2899 to
77f8bdc
Compare
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
Nov 25, 2024
Summary: X-link: meta-pytorch/botorch#2595 Adds optional `trial_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)). Reviewed By: Balandat Differential Revision: D64764019
bernardbeckerman
added a commit
to bernardbeckerman/botorch
that referenced
this pull request
Nov 25, 2024
) Summary: X-link: facebook/Ax#2960 Adds optional `trial_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)). Reviewed By: Balandat Differential Revision: D64764019
|
This pull request was exported from Phabricator. Differential Revision: D64764019 |
bernardbeckerman
added a commit
to bernardbeckerman/botorch
that referenced
this pull request
Nov 25, 2024
) Summary: X-link: facebook/Ax#2960 Adds optional `trial_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)). Reviewed By: Balandat Differential Revision: D64764019
bernardbeckerman
force-pushed
the
export-D64764019
branch
from
77f8bdc to
6976e13
Compare
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
Nov 25, 2024
Summary: X-link: meta-pytorch/botorch#2595 Adds optional `trial_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)). Reviewed By: Balandat Differential Revision: D64764019
|
This pull request was exported from Phabricator. Differential Revision: D64764019 |
) Summary: X-link: facebook/Ax#2960 Adds optional `group_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)). Reviewed By: Balandat Differential Revision: D64764019
bernardbeckerman
force-pushed
the
export-D64764019
branch
from
6976e13 to
5dc3915
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64764019 |
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
Nov 26, 2024
Summary: X-link: meta-pytorch/botorch#2595 Adds optional `group_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)). Reviewed By: Balandat Differential Revision: D64764019
|
This pull request has been merged in 2e143c9. |
facebook-github-bot
pushed a commit
to facebook/Ax
that referenced
this pull request
Nov 26, 2024
Summary: Pull Request resolved: #2960 X-link: meta-pytorch/botorch#2595 Adds optional `group_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)). Reviewed By: Balandat Differential Revision: D64764019 fbshipit-source-id: 733460c2baa84e3a73573227c48f9bb20047e241
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Adds optional
trial_indicesto SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in_validate(pointer).Differential Revision: D64764019