Support inequality constraints & X_avoid support in optimize_acqf_discrete #2593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D64841997 |
facebook-github-bot
added
CLA Signed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2593 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 196 196
Lines 17352 17363 +11
=======================================
+ Hits 17350 17361 +11
Misses 2 2 ☔ View full report in Codecov by Sentry. |
…crete (meta-pytorch#2593) Summary: These were previously handled in `Acquisition.optimize` in Ax. Pushing it down to BoTorch makes the functionality more broadly useful and helps simplify `Acquisition.optimize` (next diff). Reviewed By: Balandat Differential Revision: D64841997
saitcakmak
force-pushed
the
export-D64841997
branch
from
3cff519 to
f7e4652
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64841997 |
|
This pull request has been merged in ccf278a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: These were previously handled in
Acquisition.optimizein Ax. Pushing it down to BoTorch makes the functionality more broadly useful and helps simplifyAcquisition.optimize(next diff).Differential Revision: D64841997