Fix input constructor for qMultiFidelityKnowledgeGradient
#2519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62391106 |
…orch#2519) Summary: Pull Request resolved: meta-pytorch#2519 The input constructor for `qMultiFidelityKnowledgeGradient` was computing `current_value` in a manner that was effectively not fidelity-aware (the fidelity dimension was not fixed in the optimization done to obtain `current_value`), since it was simply re-using functionality from the input constructor for `construct_inputs_qKG`. This diff addresses this by making use of `target_fidelities` as the `fixed_features` argument to `D62380369`. Differential Revision: D62391106
|
This pull request was exported from Phabricator. Differential Revision: D62391106 |
ltiao
force-pushed
the
export-D62391106
branch
from
5201913 to
a7dff50
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2519 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 193 193
Lines 16942 16944 +2
=======================================
+ Hits 16940 16942 +2
Misses 2 2 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in d841f2b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The input constructor for
qMultiFidelityKnowledgeGradientwas computingcurrent_valuein a manner that was effectively not fidelity-aware (the fidelity dimension was not fixed in the optimization done to obtaincurrent_value), since it was simply re-using functionality from the input constructor forconstruct_inputs_qKG.This diff addresses this by making use of
target_fidelitiesas thefixed_featuresargument toD62380369.Differential Revision: D62391106