Affine input transforms should error with data of incorrect dimension, even in eval mode #2510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62318530 |
|
This pull request was exported from Phabricator. Differential Revision: D62318530 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Sep 6, 2024
…, even in eval mode (meta-pytorch#2510) Summary: Pull Request resolved: meta-pytorch#2510 Context: meta-pytorch#2509 gives a clear overview This PR: * Checks the shape of the `X` provided to an `AffineInputTransform` when it transforms the data, regardless of whether it is updating the coefficients. Makes some unrelated changes: * Fixes the example in the docstring for `batched_multi_output_to_single_output` * fixes an incorrect shape in `test_approximate_gp` * Makes data and transform batch shapes match in `TestConverters`, since those usages will now (appropriately) error Differential Revision: D62318530
esantorella
force-pushed
the
export-D62318530
branch
from
cc5c5a2 to
9a711a8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62318530 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Sep 6, 2024
…, even in eval mode (meta-pytorch#2510) Summary: Pull Request resolved: meta-pytorch#2510 Context: meta-pytorch#2509 gives a clear overview This PR: * Checks the shape of the `X` provided to an `AffineInputTransform` when it transforms the data, regardless of whether it is updating the coefficients. Makes some unrelated changes: * Fixes the example in the docstring for `batched_multi_output_to_single_output` * fixes an incorrect shape in `test_approximate_gp` * Makes data and transform batch shapes match in `TestConverters`, since those usages will now (appropriately) error Reviewed By: saitcakmak Differential Revision: D62318530
esantorella
force-pushed
the
export-D62318530
branch
from
9a711a8 to
1033c52
Compare
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Sep 6, 2024
…, even in eval mode (meta-pytorch#2510) Summary: Pull Request resolved: meta-pytorch#2510 Context: meta-pytorch#2509 gives a clear overview This PR: * Checks the shape of the `X` provided to an `AffineInputTransform` when it transforms the data, regardless of whether it is updating the coefficients. Makes some unrelated changes: * Fixes the example in the docstring for `batched_multi_output_to_single_output` * fixes an incorrect shape in `test_approximate_gp` * Makes data and transform batch shapes match in `TestConverters`, since those usages will now (appropriately) error Reviewed By: saitcakmak Differential Revision: D62318530
esantorella
force-pushed
the
export-D62318530
branch
from
1033c52 to
42e2584
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62318530 |
…, even in eval mode (meta-pytorch#2510) Summary: Pull Request resolved: meta-pytorch#2510 Context: meta-pytorch#2509 gives a clear overview This PR: * Checks the shape of the `X` provided to an `AffineInputTransform` when it transforms the data, regardless of whether it is updating the coefficients. Makes some unrelated changes: * Fixes the example in the docstring for `batched_multi_output_to_single_output` * fixes an incorrect shape in `test_approximate_gp` * Makes data and transform batch shapes match in `TestConverters`, since those usages will now (appropriately) error Reviewed By: saitcakmak Differential Revision: D62318530
|
This pull request was exported from Phabricator. Differential Revision: D62318530 |
esantorella
force-pushed
the
export-D62318530
branch
from
42e2584 to
29df54a
Compare
|
@esantorella has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2510 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 193 193
Lines 16941 16941
=======================================
Hits 16939 16939
Misses 2 2 ☔ View full report in Codecov by Sentry. |
|
@esantorella merged this pull request in 33e11f4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context: #2509 gives a clear overview
This PR:
Xprovided to anAffineInputTransformwhen it transforms the data, regardless of whether it is updating the coefficients.Makes some unrelated changes:
batched_multi_output_to_single_outputtest_approximate_gpTestConverters, since those usages will now (appropriately) errorDifferential Revision: D62318530