Clarify behavior on standard deviations with <1 degree of freedom and silence some unit test warnings #2357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@esantorella has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2357 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 190 190
Lines 16590 16603 +13
=======================================
+ Hits 16587 16600 +13
Misses 3 3 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D57931412 |
esantorella
force-pushed
the
standardize_no_df
branch
from
0e1b2c0 to
d8a3313
Compare
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Jun 11, 2024
… silence some unit test warnings (meta-pytorch#2357) Summary: ## Motivation Unit tests were producing a lot of warnings about taking standard deviations across fewer than 2 observations, and it was not clear to me if these warnings were legitimate in context. * For checking the standardization of input data, no longer check the standard deviation if there is just one observation. * For the standardize input transform, explicitly set standard deviations to 1 when there is only one observation. This actually matches the legacy behavior, but previously it wasn't clear because the standard deviation would become NaN before being corrected to 1. * Error on attempting to standardize 0 observations. This never worked so now it is more clear. Pull Request resolved: meta-pytorch#2357 Test Plan: Added units ## Related PRs Reviewed By: Balandat Differential Revision: D57931412 Pulled By: esantorella
… silence some unit test warnings (meta-pytorch#2357) Summary: ## Motivation Unit tests were producing a lot of warnings about taking standard deviations across fewer than 2 observations, and it was not clear to me if these warnings were legitimate in context. * For checking the standardization of input data, no longer check the standard deviation if there is just one observation. * For the standardize input transform, explicitly set standard deviations to 1 when there is only one observation. This actually matches the legacy behavior, but previously it wasn't clear because the standard deviation would become NaN before being corrected to 1. * Error on attempting to standardize 0 observations. This never worked so now it is more clear. Pull Request resolved: meta-pytorch#2357 Test Plan: Added units ## Related PRs Reviewed By: Balandat Differential Revision: D57931412 Pulled By: esantorella
|
This pull request was exported from Phabricator. Differential Revision: D57931412 |
esantorella
force-pushed
the
standardize_no_df
branch
from
d8a3313 to
cdcc6c0
Compare
|
@esantorella merged this pull request in f79d608. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Unit tests were producing a lot of warnings about taking standard deviations across fewer than 2 observations, and it was not clear to me if these warnings were legitimate in context.
Test Plan
Added units
Related PRs