Remove unused ** arguments #2327
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56828338 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2327 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 189 189
Lines 16669 16669
=======================================
Hits 16665 16665
Misses 4 4 ☔ View full report in Codecov by Sentry. |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
May 1, 2024
Summary: Pull Request resolved: meta-pytorch#2327 In the process of auditing places where arguments (especially of the ** form) are ignored in BoTorch, I fixed the occurrences that seemed easy. Differential Revision: D56828338
esantorella
force-pushed
the
export-D56828338
branch
from
67f92f3 to
858dc15
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56828338 |
esantorella
force-pushed
the
export-D56828338
branch
from
858dc15 to
c0122ef
Compare
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
May 2, 2024
Summary: Pull Request resolved: meta-pytorch#2327 In the process of auditing places where arguments (especially of the ** form) are ignored in BoTorch, I fixed the occurrences that seemed easy. Reviewed By: saitcakmak Differential Revision: D56828338
|
This pull request was exported from Phabricator. Differential Revision: D56828338 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
May 3, 2024
Summary: In the process of auditing places where arguments (especially of the ** form) are ignored in BoTorch, I fixed the occurrences that seemed easy. Reviewed By: saitcakmak Differential Revision: D56828338
esantorella
force-pushed
the
export-D56828338
branch
from
c0122ef to
7484343
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56828338 |
Summary: In the process of auditing places where arguments (especially of the ** form) are ignored in BoTorch, I fixed the occurrences that seemed easy. Reviewed By: saitcakmak Differential Revision: D56828338
esantorella
force-pushed
the
export-D56828338
branch
from
7484343 to
e803e69
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56828338 |
|
This pull request has been merged in 07f12b7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: In the process of auditing places where arguments (especially of the ** form) are ignored in BoTorch, I fixed the occurrences that seemed easy.
Differential Revision: D56828338