Skip to content

Conversation

@SebastianAment
Copy link
Contributor

Summary: This commit adds support for a diagonal covariance root in conjunction with fixed indices for ESS. This is not generally supported, as the root would have to be re-factorized. The diagonal case allows for an efficient implementation without re-factorization.

Differential Revision: D55808235

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 5, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55808235

@codecov
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (dc219ca) to head (fb43775).
Report is 2 commits behind head on main.

❗ Current head fb43775 differs from pull request most recent head 036c5c1. Consider uploading reports for the commit 036c5c1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2283   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files         197      197           
  Lines       17165    17156    -9     
=======================================
- Hits        17160    17152    -8     
+ Misses          5        4    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55808235

SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Apr 5, 2024
…ch#2283)

Summary:

This commit adds support for a diagonal covariance root in conjunction with fixed indices for ESS. This is not generally supported, as the root would have to be re-factorized. The diagonal case allows for an efficient implementation without re-factorization.

Differential Revision: D55808235
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55808235

SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Apr 14, 2024
…ch#2283)

Summary:

This commit adds support for a diagonal covariance root in conjunction with fixed indices for ESS. This is not generally supported, as the root would have to be re-factorized. The diagonal case allows for an efficient implementation without re-factorization.

Reviewed By: Balandat

Differential Revision: D55808235
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55808235

…ch#2283)

Summary:

This commit adds support for a diagonal covariance root in conjunction with fixed indices for ESS. This is not generally supported, as the root would have to be re-factorized. The diagonal case allows for an efficient implementation without re-factorization.

Reviewed By: Balandat

Differential Revision: D55808235
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55808235

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 7c28a20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants