Error out if scipy optimizer does not support bounds / constraints #2282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D55724311 |
facebook-github-bot
added
CLA Signed
…eta-pytorch#2282) Summary: Scipy ignores the bounds / constraints with a warning, if the given method does not support them. This can lead to significant bugs if the warning is filtered out somewhere. Scipy behavior: https://github.com/scipy/scipy/blob/v1.13.0/scipy/optimize/_minimize.py#L577-L584 Differential Revision: D55724311
saitcakmak
force-pushed
the
export-D55724311
branch
from
c0b0c76 to
6364123
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55724311 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2282 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 197 197
Lines 17149 17151 +2
=======================================
+ Hits 17145 17147 +2
Misses 4 4 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 968e465. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Scipy ignores the bounds / constraints with a warning, if the given method does not support them. This can lead to significant bugs if the warning is filtered out somewhere.
Scipy behavior: https://github.com/scipy/scipy/blob/v1.13.0/scipy/optimize/_minimize.py#L577-L584
Differential Revision: D55724311