Reap requires_grad_ctx #2252
Closed
Reap requires_grad_ctx #2252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This was deprecated a long time ago. Reviewed By: saitcakmak Differential Revision: D55026015
Summary: This may be controversial, as `requires_grad_ctx` could be useful. However, it is no longer used outside tests after reaping `fit_gpytorch_mll`, and users will not make use of this unless we highlight it in tutorials or other worked examples. Reviewed By: saitcakmak Differential Revision: D55027020
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55027020 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2252 +/- ##
==========================================
- Coverage 99.97% 99.97% -0.01%
==========================================
Files 197 197
Lines 17195 17163 -32
==========================================
- Hits 17191 17159 -32
Misses 4 4 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 1a8b4ea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This may be controversial, as
requires_grad_ctxcould be useful. However, it is no longer used outside tests after reapingfit_gpytorch_mll, and users will not make use of this unless we highlight it in tutorials or other worked examples.Reviewed By: saitcakmak
Differential Revision: D55027020