Fix invariant that factory ops should have input specs #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The solver assumes all ops (including placeholder and factory ops) have an input spec. So let's just respect this condition in the code
meta-cla
bot
added
the
CLA Signed
wconstab
approved these changes
Aug 4, 2025
Contributor
wconstab
left a comment
wconstab
left a comment
There was a problem hiding this comment.
Seems ok to me to unblock. It feels in principle cleaner to make the solver aware of the factory ops, but it might not be worth the trouble.
Contributor
Author
|
Yeah, we can try seeing if it would be feasible to handle it in the solver, but I'm not sure as we currently do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solver assumes all ops (including placeholder and factory ops) have an input spec. So let's just respect this condition in the code.
Split from #29