Add an integration test for redis KVStore and ensure it has functional parity with other KVStores #506
Labels
good first issue
Good for newcomers
Comments
|
I'd like to take this up! |
6 tasks
|
@dineshyv I think this issue is mistaken. We don't have a Redis memory provider. 
Did you perhaps mean Redis as a Key-Value (KV) store? |
dineshyv
changed the title
|
Ah, thanks for catching this. Corrected the issue. |
vishwamartur
added a commit
to vishwamartur/llama-stack
that referenced
this issue
Dec 14, 2024
Related to meta-llama#506 Add integration tests for Redis KVStore to ensure functional parity with other KVStores. * **`llama_stack/distribution/store/tests/test_registry.py`**: - Add fixture for `RedisKVStoreConfig`. - Add tests for `RedisKVStoreConfig` covering initialization, connection, CRUD operations, namespaced keys, expiration handling, error handling, and concurrency. - Add tests for `redis_registry` and `cached_redis_registry` to verify registration, retrieval, and updates of memory banks and models. * **`llama_stack/providers/tests/memory/test_memory.py`**: - Add fixture for `RedisKVStoreConfig`. - Add tests for `redis_kvstore` covering initialization, CRUD operations, namespaced keys, expiration handling, error handling, and concurrency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🚀 The feature, motivation and pitch
Redis KVStore has been relatively less used and does not yet have an integration test fixture . We need to add a fixture for it here and test the end to end flow.
Alternatives
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: