Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix toolcalling timestamp #22

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Fix toolcalling timestamp #22

merged 2 commits into from
Feb 25, 2025

Conversation

Riandy
Copy link
Contributor

@Riandy Riandy commented Feb 25, 2025

  • 0.1.4 server started returning completed_at and started_at timestamp, but it's not compliant with the OffsetDateTime format that SDK expects. This is causing the agentTurnResponseStepComplete to be missing/incorrectly type-casted to unknown. This patch will ignore the timestamp for now, at least until 0.1.5 release next week when the format is corrected on server side.

@Riandy
Fix toolcalling timestamp bug
b499edb 
- 0.1.4 server started returning completed_at and started_at timestamp, but it's not compliant with the OffsetDateTime format that SDK expects. This is causing the agentTurnResponseStepComplete to be missing/incorrectly type-casted to unknown. This patch will ignore the timestamp for now, at least until 0.1.5 release next week when the format is corrected on server side.
@Riandy
Update readme and bump version
81dbb7b
raghotham
raghotham approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@raghotham raghotham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you create an issue to fix this once 0.1.5 llama stack server has the timestamp fix?

@Riandy Riandy mentioned this pull request Feb 25, 2025
Open
@Riandy
Copy link
Contributor Author

Riandy commented Feb 25, 2025

can you create an issue to fix this once 0.1.5 llama stack server has the timestamp fix?

tracking them here #23

@Riandy Riandy merged commit 038528b into main Feb 25, 2025
1 check passed
@Riandy Riandy deleted the fix-toolcalling-timestamp branch February 25, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raghotham raghotham raghotham approved these changes

@ashwinb ashwinb Awaiting requested review from ashwinb ashwinb is a code owner

@yanxi0830 yanxi0830 Awaiting requested review from yanxi0830 yanxi0830 is a code owner

@hardikjshah hardikjshah Awaiting requested review from hardikjshah hardikjshah is a code owner

@dltn dltn Awaiting requested review from dltn dltn is a code owner

@WuhanMonkey WuhanMonkey Awaiting requested review from WuhanMonkey WuhanMonkey is a code owner

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Riandy @raghotham @facebook-github-bot