add vertex notebooks for gcp #958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agunapal
requested changes
Jun 9, 2025
There was a problem hiding this comment.
@terencezhang1997 Could you please add a README to the GCP folder with information on relevant VertexAI pieces ( think how would this GCP folder be structures for any future notebooks
sithreach
approved these changes
Jun 12, 2025
|
addressed comments, thanks @agunapal ! |
agunapal
approved these changes
Jun 20, 2025
There was a problem hiding this comment.
@terencezhang1997 Looks good to me. Approving this. Please consider editing the README in another PR, which talks in more detail about Llama on GCP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds notebooks to provide examples for tool calling and JSON mode via Vertex AI MaaS on GCP.