hello ci world #113
Merged
hello ci world #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @dzyanis ! I found a problem. In this PR I'm running the tests and this is breaking I think it's because when you iterate over a map the order is random. See https://go.dev/blog/maps#iteration-order Can you help me fix it? I'm not sure how 🙏🏽 Also I'm not sure the lint is running according to the configuration. It passed on this run https://github.com/messagebird/sachet/runs/5597776651?check_suite_focus=true#step:4:74 but it tried to make a mistake on purpose here: 22909da |
|
Hey!
1/ Just comment the test case `alerts labels` and leave TODO like that:
[image: image.png]
I will fix it later
2/ You need to add `t.Parallel()` line in the begging of the test
3/ If some linter just broke something and you don't know how to fix that
it's okay just disable it and back to the problem later. They are not so
critical
have a nice day
…On Fri, Mar 18, 2022 at 11:55 AM marcel corso gonzalez < ***@***.***> wrote:
hey @dzyanis <https://github.com/dzyanis> ! I found a problem.
In this PR I'm running the tests and this is breaking
https://github.com/messagebird/sachet/runs/5597776654?check_suite_focus=true#step:5:33
sometimes.
I think it's because when you iterate over a map the order is random. See
https://go.dev/blog/maps#iteration-order
Can you help me fix it? I'm not sure how 🙏🏽
Also I'm not sure the lint is running according to the configuration. It
passed on this run
https://github.com/messagebird/sachet/runs/5597776651?check_suite_focus=true#step:4:74
but it tried to make a mistake on purpose here: 22909da
<22909da>
—
Reply to this email directly, view it on GitHub
<#113 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFBV3O2H2WE3YPTXM7IW43VARAGZANCNFSM5RBFEOTQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
*Dzyanis Kuzmenka*
Mobile: +375 29 196-28-94
LinkedIn: linkedin.com/in/dzeveloper
<https://www.linkedin.com/in/dzeveloper>
Github: github.com/dzyanis
|
dzyanis
reviewed
Mar 18, 2022
cmd/sachet/main_test.go
Outdated
| @@ -20,3 +20,8 @@ func Test_errorHandler(t *testing.T) { | |||
| errorHandler(w, http.StatusForbidden, err, "test") | |||
| assert.Equal(t, expect, w.Body.String()) | |||
| } | |||
|
|
|||
| func Test_fail(t *testing.T) { | |||
| // TODO also try to fail lint? | |||
There was a problem hiding this comment.
You need to add t.Parallel() in the begging of the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.