Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add no_stop and priority options to OVH provider #103

Merged
merged 3 commits into from
Nov 16, 2021
Merged

add no_stop and priority options to OVH provider #103

merged 3 commits into from
Nov 16, 2021

Conversation

BDelacour
Copy link
Contributor

@BDelacour BDelacour commented Nov 12, 2021 •
edited
Loading

Hello

Just adding no_stop_clause config to OVH provider and leave default value to false (bool is false by default) to respect old configuration.

@BDelacour BDelacour changed the title add NoStopClause parameter to ovh provider add no_stop and priority options to OVH provider Nov 15, 2021
@BDelacour
Copy link
Contributor Author

Just added priority option because (apparently) the SMS won't be sent on non-working days with the default option.

@marcelcorso, may you have a look at this PR please ?

@marcelcorso marcelcorso merged commit 2964ecf into messagebird:master Nov 16, 2021
@BDelacour
Copy link
Contributor Author

Thanks for your time @marcelcorso 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BDelacour @marcelcorso