Skip to content

Conversation

@lucasmichot
Copy link

This PR optimizes or conditions.

@CoolGoose
Copy link
Contributor

@lucasmichot what's the reason for this change ?

@lucasmichot
Copy link
Author

@CoolGoose or and || do not do the same thing. Even if both their operations are a logical or, they don't have the same precedence.
The same precedence concept also applies to and and &&.

|| and && should always be used over or and and, unless there is a very good not to do.

@lucasmichot
Copy link
Author

I guess this PR can safely be merged @CoolGoose

@CoolGoose CoolGoose merged commit f4a4114 into messagebird:master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants