Skip to content

Conversation

@lucasmichot
Copy link

@lucasmichot lucasmichot commented Mar 2, 2021

This PR moves tests from TravisCI to Github Actions.

Also, the need for a separate composer.json is removed, by simply setting up a new phpunit version constraint.


@bviolier, I guess that the Github Actions need to be enabled for this repository.

@rfeiner
Copy link
Contributor

rfeiner commented Mar 3, 2021

Thanks @lucasmichot! GH Actions is already enabled, we will have a look at this PR.

@lucasmichot
Copy link
Author

This is strange @rfeiner as https://github.com/messagebird/php-rest-api/actions displays no workflow run.
As a comparison, you can see the ones that have run for my fork of this repository, for this specific PR: https://github.com/lucasmichot/php-rest-api/actions

Side-note, 08a69b6 was forced pushed to attempt a re-trigger of the workflow provided in this PR.

Here are my settings that you might want to compare with the ones of this repository:

image

@rfeiner
Copy link
Contributor

rfeiner commented Mar 3, 2021

We will merge the PR. I believe the actions are not running because your branch is not living in GitHub's messagebird/php-rest-api namespace

@CoolGoose CoolGoose merged commit b730cba into messagebird:master Mar 3, 2021
@lucasmichot lucasmichot deleted the feature/github-actions branch March 8, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants